LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] prevent oops from read of proc entry for tty drivers
       [not found] ` <20031125004716.GA28135@kroah.com>
@ 2003-11-25 19:26   ` Stephen Hemminger
  0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2003-11-25 19:26 UTC (permalink / raw)
  To: Greg KH; +Cc: Rusty Russell, linux-kernel

There are /proc handles there setup by proc_tty_register_driver, but there is
no module ownership association, so anything that reads after module unload
will blow.  Fix is to propagate owner of tty_driver to proc entry.

diff -Nru a/fs/proc/proc_tty.c b/fs/proc/proc_tty.c
--- a/fs/proc/proc_tty.c	Tue Nov 25 11:18:53 2003
+++ b/fs/proc/proc_tty.c	Tue Nov 25 11:18:53 2003
@@ -198,6 +198,7 @@
 		return;
 	ent->read_proc = driver->read_proc;
 	ent->write_proc = driver->write_proc;
+	ent->owner = driver->owner;
 	ent->data = driver;
 
 	driver->proc_entry = ent;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-11-25 19:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20031124155222.6b44d2a3.shemminger@osdl.org>
     [not found] ` <20031125004716.GA28135@kroah.com>
2003-11-25 19:26   ` [PATCH] prevent oops from read of proc entry for tty drivers Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).