LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Hinds <dhinds@sonic.net>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] Ricoh Cardbus -> Can't get interrupts
Date: Thu, 27 Nov 2003 10:56:12 -0800	[thread overview]
Message-ID: <20031127105612.B28106@sonic.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0311241906500.1986-100000@bigblue.dev.mdolabs.com>

On Mon, Nov 24, 2003 at 07:08:26PM -0800, Davide Libenzi wrote:
> 
> I didn't want to post this because I was ashamed of the fix, but w/out 
> this my orinoco cardbus gets an interrupt one every ten boots. This is 
> against 2.4.20 ...
> 
> - Davide

Your patch seems to do two things:

First, it automatically falls back on using a socket's PCI interrupt
if its ISA interrupts are not available.  That part seems ok.

But, it also falls back on sharing an interrupt if a driver requested
an exclusive interrupt and that was not available.  This part is not
ok.  The original code will share a PCI interrupt automatically, but
will not share an ISA interrupt except under certain circumstances
(for multifunction cards or when the driver specifically requests it).
Sharing ISA interrupts is unsafe and should never be done blindly.

-- Dave

  parent reply	other threads:[~2003-11-27 18:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-24 23:57 Jean Tourrilhes
2003-11-25  0:16 ` glee
2003-11-25  0:37   ` Jean Tourrilhes
2003-11-25  0:26 ` David Hinds
2003-11-25  0:49   ` Jean Tourrilhes
2003-11-25  2:06     ` Linus Torvalds
2003-11-25  2:33       ` Jean Tourrilhes
2003-11-25  2:49         ` Linus Torvalds
2003-11-25  2:52           ` Linus Torvalds
2003-11-25  3:11             ` Jean Tourrilhes
2003-11-25  3:25               ` Linus Torvalds
     [not found]                 ` <20031125034815.GC4483@bougret.hpl.hp.com>
     [not found]                   ` <Pine.LNX.4.58.0311242028220.1599@home.osdl.org>
     [not found]                     ` <Pine.LNX.4.58.0311242100540.1599@home.osdl.org>
2003-11-26  1:54                       ` Jean Tourrilhes
2003-11-25  3:08           ` Davide Libenzi
2003-11-26  1:59             ` Jean Tourrilhes
2003-11-26  2:17               ` Davide Libenzi
2003-11-27 18:56             ` David Hinds [this message]
2003-11-27 20:15               ` Davide Libenzi
2003-11-25  2:03 ` Linus Torvalds
2003-11-25  2:24   ` Linus Torvalds
2003-11-25  2:56     ` Jean Tourrilhes
2003-11-25  3:03       ` Linus Torvalds
2003-11-25  3:38         ` Jean Tourrilhes
2003-11-25 10:41       ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031127105612.B28106@sonic.net \
    --to=dhinds@sonic.net \
    --cc=davidel@xmailserver.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [BUG] Ricoh Cardbus -> Can'\''t get interrupts' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).