LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tonnerre Anklin <thunder@keepsake.ch>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [I4L] isdn_ppp_ccp.c uses uninitialized spinlock
Date: Fri, 28 Nov 2003 02:41:20 +0100	[thread overview]
Message-ID: <20031128014120.GD1635@dbintra.dmz.lightweight.ods.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

Salut,

This spinlock was used uninitialized. Gave me a lot of warnings.

More on this patch can be found at
<URL:http://keepsake.keepsake.ch/~thunder/noyau/2.6.0-test11-ta1/isdn_ccp_uninitialized_spinlock.xml>

				Thunder

diff -Nur linux-2.6.0-test9-mm3/drivers/isdn/i4l/isdn_ppp_ccp.c linux-2.6.0-test9-mm3-ta1/drivers/isdn/i4l/isdn_ppp_ccp.c
--- linux-2.6.0-test9-mm3/drivers/isdn/i4l/isdn_ppp_ccp.c	2003-10-08 21:24:04.000000000 +0200
+++ linux-2.6.0-test9-mm3-ta1/drivers/isdn/i4l/isdn_ppp_ccp.c	2003-11-24 13:41:47.000000000 +0100
@@ -557,7 +557,7 @@
 }
 
 static LIST_HEAD(ipc_head);
-static spinlock_t ipc_head_lock;
+static spinlock_t ipc_head_lock = SPIN_LOCK_UNLOCKED;
 
 int
 ippp_ccp_set_compressor(struct ippp_ccp *ccp, int unit,

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

                 reply	other threads:[~2003-11-28  2:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031128014120.GD1635@dbintra.dmz.lightweight.ods.org \
    --to=thunder@keepsake.ch \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [I4L] isdn_ppp_ccp.c uses uninitialized spinlock' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).