LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Faik Uygur <faikuygur@tnn.net>
To: Andrew Morton <akpm@osdl.org>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use idr_get_new to allocate a bus id in drivers/i2c/i2c-core.c
Date: Sun, 16 May 2004 12:13:13 +0300	[thread overview]
Message-ID: <20040516091312.GA2052@tnn.net> (raw)
In-Reply-To: <20040515165812.7e771f20.akpm@osdl.org>

On Sat, 15 May 2004, Andrew Morton wrote:

> The IDR interface is a bit cumbersome.  Even though you called
> idr_pre_get(), there's no guarantee that the memory which it preallocated
> is still present when you call idr_get_new().

Thanks for the correction.

> Is the kernel likely to ever have so many bus IDs that we actually need
> this patch?  Or do you specifically want first-fit-from-zero for some
> reason?

Actually there is no special need for this. It is just what i think would
be the expected behaviour. There was a thread two weeks ago about this issue:

http://marc.theaimsgroup.com/?l=linux-kernel&m=108370586601550&w=2

here is the updated patch:

diff -Nru a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
--- a/drivers/i2c/i2c-core.c	Sun May 16 11:55:29 2004
+++ b/drivers/i2c/i2c-core.c	Sun May 16 11:55:29 2004
@@ -28,6 +28,7 @@
 #include <linux/slab.h>
 #include <linux/i2c.h>
 #include <linux/init.h>
+#include <linux/idr.h>
 #include <linux/seq_file.h>
 #include <asm/uaccess.h>
 
@@ -35,6 +36,7 @@
 static LIST_HEAD(adapters);
 static LIST_HEAD(drivers);
 static DECLARE_MUTEX(core_lists);
+static DEFINE_IDR(i2c_adapter_idr);
 
 int i2c_device_probe(struct device *dev)
 {
@@ -113,13 +115,19 @@
  */
 int i2c_add_adapter(struct i2c_adapter *adap)
 {
-	static int nr = 0;
+	int id, res = 0;
 	struct list_head   *item;
 	struct i2c_driver  *driver;
 
 	down(&core_lists);
 
-	adap->nr = nr++;
+	if (idr_pre_get(&i2c_adapter_idr, GFP_KERNEL) == 0) {
+		res = -ENOMEM;
+		goto out_unlock;
+	}
+
+	id = idr_get_new(&i2c_adapter_idr, NULL);
+	adap->nr =  id & MAX_ID_MASK;
 	init_MUTEX(&adap->bus_lock);
 	init_MUTEX(&adap->clist_lock);
 	list_add_tail(&adap->list,&adapters);
@@ -151,10 +159,12 @@
 			/* We ignore the return code; if it fails, too bad */
 			driver->attach_adapter(adap);
 	}
-	up(&core_lists);
 
 	dev_dbg(&adap->dev, "registered as adapter #%d\n", adap->nr);
-	return 0;
+
+ out_unlock:
+	up(&core_lists);
+	return res;
 }
 
 
@@ -207,6 +217,9 @@
 	/* wait for sysfs to drop all references */
 	wait_for_completion(&adap->dev_released);
 	wait_for_completion(&adap->class_dev_released);
+
+	/* free dynamically allocated bus id */
+	idr_remove(&i2c_adapter_idr, adap->nr);
 
 	dev_dbg(&adap->dev, "adapter unregistered\n");


  reply	other threads:[~2004-05-16  9:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-15 22:26 Faik Uygur
2004-05-15 23:58 ` Andrew Morton
2004-05-16  9:13   ` Faik Uygur [this message]
2004-05-16  9:36     ` Andrew Morton
2004-05-19  7:07     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040516091312.GA2052@tnn.net \
    --to=faikuygur@tnn.net \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] use idr_get_new to allocate a bus id in drivers/i2c/i2c-core.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).