Linux 2.4.27-pre2

Linux 2.4.27-pre2

[Marcelo Tosatti]

Hi, 

Here goes the second pre release of 2.4.27.

It contains m68k/SPARC, XFS and networking updates, big PCI hotplug
update, gcc3 fixes, riva fixes, IDE update, amongst others.

Please read the detailed changelog

Summary of changes from v2.4.27-pre1 to v2.4.27-pre2
============================================

<aj:andaco.de>:
  o [TG3]: Fix typo in TG3_TSO_FW_RODATA_ADDR definition

<gandalf:winds.org>:
  o Blue line in nVidia framebuffer (rivafb)

<jkmaline:cc.hut.fi>:
  o [CRYPTO]: Add suuport for keyed digests
  o [CRYPTO]: Add Michael MIC algorithm

<jpk:sgi.com>:
  o [XFS] Correct the (file size >= stripe unit) check inside xfs_iomap_write_delay.  It was comparing the file size, in bytes, against the stripe unit size, in FSBs.

<mchan:broadcom.com>:
  o [TG3]: Jumbo frames and FTQ reset patch
  o [TG3]: Fix jumbo frame PHY programming

Andrea Arcangeli:
  o Fix page-free-at-IRQ context BUG

Bartlomiej Zolnierkiewicz:
  o IDE PCI: fix support for PIO modes w/o IORDY flow control
  o serverworks.c: fix DMA for OSB4 (Patrick Wildi)
  o generic PCI IDE support for more Toshiba Piccolo chips (Daniel Drake)

Chas Williams:
  o [ATM]: get atm_guess_pdu2truesize() right
  o [ATM]: [nicstar] using dev_alloc_skb() (reported by Johnston,
  o [ATM]: [fore200e] 0.3e version by Christophe Lizzi (lizzi@cnam.fr)
  o [ATM]: [fore200e] make tasklet use configurable

Chris Wright:
  o [IPV4]: Fix return value on MCAST_MSFILTER error case

Christoph Hellwig:
  o [XFS] use kmem_alloc for noaddr buffers
  o [XFS] kill the pagebuf vs xfs_buf confusion
  o [XFS] really kill the pagebuf vs xfs_buf confusion
  o [XFS] clarify pagebuf page lookup logic
  o [XFS] cleanup pagebuf flag usage and simplify pagebuf_free
  o [XFS] close external blockdevice after final flush

David S. Miller:
  o [TG3]: Just completely delete the disabled FTQ reset code
  o [SPARC64]: Kill cast as lvalue usage in pgd/pmd macros
  o [SPARC64]: Fix rest of cast as lvalue usage in sparc64 code
  o [TG3]: Kill 'force' arg to tg3_phy_reset, it is always set
  o [TG3]: At start of tg3_phy_copper_begin, force phy out of loopback mode
  o [TG3]: Do not allow illegal ethtool advertisement bits
  o [SPARC64]: Export prom_palette
  o [TG3]: Add missing 5704 BX workaround, and fix typo in autoneg fix
  o [TG3]: Set GRC_MISC_CFG prescaler more safely
  o [TG3]: Fix serdes cfg programming on 5704
  o [TG3]: When link is down, set stats coalescing ticks to zero
  o [TG3]: Wait a bit for BMSR/BMCR bits to settle in PHY setup
  o [TG3]: Verify link advertisement correctly on 10/100 only chips
  o [TG3]: All 5705 chips need PHY reset on link-down
  o [TG3]: More PHY programming fixes
  o [TG3]: Bump driver version and reldate
  o [TG3]: Print list of important probed capabilities at driver load
  o [TG3]: Two PHY fixes
  o [TG3]: Kill uninitialized var warning
  o [TG3]: Reset fixes
  o [TG3]: Update driver version and release date
  o [SPARC]: Use 64 for KERN_SPARC_SCONS_PWROFF to prevent 2.6.x conflicts
  o [TG3]: Update driver version and reldate
  o [TG3]: Undo comment typo fix, it was wrong
  o [SPARC64]: Fix zero-extension issues wrt. {pgd,pmd}_val()
  o [SPARC64]: Update defconfig

David Stevens:
  o [IPV4]: Fix IGMP version number and timer printing for procfs

Dely Sy:
  o SHPC and PCI Express hot-plug drivers for 2.4 kernel
  o PCI Hotplug: SHPC & PCI-E hot-plug fixes

Eric Brower:
  o [SPARC]: Add sysctl to control serial console power-off restrictions
  o [SPARC64]: HDIO_DRIVE_TASK is a compatible ioctl

Eric Sandeen:
  o [XFS] Use pgoff_t for page indices, and remove some other type confusion
  o [XFS] New PFLAGS_RESTORE_FSTRANS macro to restore only FSTRANS state from saved state.

Geert Uytterhoeven:
  o [NET]: Make pktgen depend upon procfs
  o NCR53C9x unused SCp.have_data_in
  o M68k TLB fixes
  o Amiga A2065 Ethernet debug

Grant Grundler:
  o [TG3]: Fix comment typo

Harald Welte:
  o [NETFILTER]: Add more debug info to TFTP helper

Hideaki Yoshifuji:
  o [IPV6]: Mark MLDv2 report as known
  o [IPV6]: Use IANA icmpv6 type for MLDv2 report

Jakub Bogusz:
  o rivafb 16bpp text background colour fix

Jamal Hadi Salim:
  o [NET_SCHED]: Check for NULL opt in dsmark_init

Jeff Garzik:
  o [TG3]: Dump NIC-specific statistics via ethtool

Jon Oberheide:
  o [CRYPTO]: ARC4 config help clarification

Marcel Holtmann:
  o [Bluetooth] Allow normal users to release the previous created TTY
  o [Bluetooth] Fix race in RX complete routine of the USB drivers
  o [Bluetooth] Make use of request_firmware() for the 3Com driver
  o [Bluetooth] Add UART protocol id's for 3-Wire and H4DS

Marcelo Tosatti:
  o Andrew Morton: __free_pages_ok() stress testing
  o Changed EXTRAVERSION to -pre2

Matt Porter:
  o ppc32: fix head_44x.S copyrights

Nathan Scott:
  o [XFS] Fix a very hard-to-hit, small-block-size only corruption
  o [XFS] Fix delayed write buffer handling to use the correct list interfaces, add validity checks, remove unused code, fix comments.
  o [XFS] Make buffer error checking consistent, add a value range check
  o [XFS] Return the right error code on an ACL xattr version mismatch
  o [XFS] Allow xfsbufd flush intervals to take immediate effect after changing the flush sysctl value.  Fix from Bart Samwel.
  o [XFS] Clear the superblock dirty flag after flushing the log in sync_super.
  o [XFS] Fix vmtruncate abuse in the XFS setattr ATTR_SIZE operation
  o [XFS] make return value type for read() really ssize_t
  o [XFS] Define a new superblock field for more feature bits
  o [XFS] Fix debug builds - need sb_features2 details in the endian translation code.
  o Remove a bk ignored XFS cvs directory, accidentally added
  o Fix typo in delayed allocate buffer count reporting (sysrq-m)
  o Minor updates to XFS documentation
  o [XFS] Fix fsync regression resulting from moving data flushing out from under the IOLOCK.
  o [XFS] Remove extraneous vmtruncate call, missed in earlier merge
  o [XFS] Remove xfs_iaccess checks on security extended attribute namespace, done outside the filesystem.

Russell Cattelan:
  o [XFS] Fix for the xfs dir2 rebalance bug

Rusty Russell:
  o [NETFILTER]: Missing ip_rt_put in ipt_MASQUERADE

Sridhar Samudrala:
  o [SCTP] Fix typo in entry name of the remove_proc_entry() call
  o [SCTP] Update sctp_ulpevent structure to include assoc pointer and
  o [SCTP] Avoid the use of constant SCTP_IP_OVERHEAD to determin the max data size in a SCTP packet.
  o [SCTP] Cleanup sctp_packet and sctp_outq infrastructure
  o [SCTP] Partial Reliability Extension support
  o [SCTP] Propagate error from sctp_proc_init. (Olaf Kirch)

Stephen C. Tweedie:
  o fix O(N^2) dquot sync behaviour

Takayoshi Kochi:
  o PCI Hotplug: acpiphp unable to power off slots

Takayoshi Kouchi:
  o PCI Hotplug: acpiphp cleanup patch for 2.4.23-pre4

William Lee Irwin III:
  o Joel Becker: Fix summit crash: cpu_present_to_apicid() bound checking

Zwane Mwaikambo:
  o fix module load with gcc3.3.3
  o Fix typo in include/linux/compiler.h

Re: Linux 2.4.27-pre2

[Frédéric L. W. Meunier]

On Mon, 3 May 2004, Marcelo Tosatti wrote:

> Here goes the second pre release of 2.4.27.

Where is it ? I can't find it at
http://ftp.kernel.org/pub/linux/kernel/v2.4/testing/ (or
ftp://).

-- 
http://www.pervalidus.net/contact.html

Re: Linux 2.4.27-pre2 (gcc-3.4.0)

[Rafał 'rmrmg' Roszak]

[-- Attachment #1: Type: text/plain, Size: 4819 bytes --]

begin  Marcelo Tosatti <marcelo.tosatti@cyclades.com> quote:
 
> Here goes the second pre release of 2.4.27.

make[2]: Entering directory `/usr/src/linux-2.4.27-pre2/kernel'
gcc -D__KERNEL__ -I/usr/src/linux-2.4.27-pre2/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon  
-nostdinc -iwithprefix include -DKBUILD_BASENAME=sched 
-fno-omit-frame-pointer -c -o sched.o sched.c sched.c:213: error:
conflicting types for 'reschedule_idle' sched.c:210: error: previous
declaration of 'reschedule_idle' was here sched.c:213: error:
conflicting types for 'reschedule_idle' sched.c:210: error: previous
declaration of 'reschedule_idle' was here sched.c:371: error:
conflicting types for
'wake_up_process'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:603:
error: previous declaration of 'wake_up_process' was here sched.c:371:
error: conflicting types for
'wake_up_process'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:603:
error: previous declaration of 'wake_up_process' was here sched.c:409:
error: conflicting types for
'schedule_timeout'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:148:
error: previous declaration of 'schedule_timeout' was here sched.c:409:
error: conflicting types for
'schedule_timeout'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:148:
error: previous declaration of 'schedule_timeout' was here sched.c:739:
error: conflicting types for
'__wake_up'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:595: error:
previous declaration of '__wake_up' was here sched.c:739: error:
conflicting types for
'__wake_up'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:595: error:
previous declaration of '__wake_up' was here sched.c:749: error:
conflicting types for
'__wake_up_sync'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:596:
error: previous declaration of '__wake_up_sync' was here sched.c:749:
error: conflicting types for
'__wake_up_sync'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:596:
error: previous declaration of '__wake_up_sync' was here sched.c:759:
error: conflicting types for
'complete'/usr/src/linux-2.4.27-pre2/include/linux/completion.h:31:
error: previous declaration of 'complete' was here sched.c:759: error:
conflicting types for
'complete'/usr/src/linux-2.4.27-pre2/include/linux/completion.h:31:
error: previous declaration of 'complete' was here sched.c:769: error:
conflicting types for
'wait_for_completion'/usr/src/linux-2.4.27-pre2/include/linux/completio
n.h:30: error: previous declaration of 'wait_for_completion' was here
sched.c:769: error: conflicting types for
'wait_for_completion'/usr/src/linux-2.4.27-pre2/include/linux/completio
n.h:30: error: previous declaration of 'wait_for_completion' was here
sched.c:804: error: conflicting types for
'interruptible_sleep_on'/usr/src/linux-2.4.27-pre2/include/linux/sched.
h:600: error: previous declaration of 'interruptible_sleep_on' was here
sched.c:804: error: conflicting types for
'interruptible_sleep_on'/usr/src/linux-2.4.27-pre2/include/linux/sched.
h:600: error: previous declaration of 'interruptible_sleep_on' was here
sched.c:815: error: conflicting types for
'interruptible_sleep_on_timeout'/usr/src/linux-2.4.27-pre2/include/linu
x/sched.h:601: error: previous declaration of
'interruptible_sleep_on_timeout' was here sched.c:815: error:
conflicting types for
'interruptible_sleep_on_timeout'/usr/src/linux-2.4.27-pre2/include/linu
x/sched.h:601: error: previous declaration of
'interruptible_sleep_on_timeout' was here sched.c:828: error:
conflicting types for
'sleep_on'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:597: error:
previous declaration of 'sleep_on' was here sched.c:828: error:
conflicting types for
'sleep_on'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:597: error:
previous declaration of 'sleep_on' was here sched.c:839: error:
conflicting types for
'sleep_on_timeout'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:598:
error: previous declaration of 'sleep_on_timeout' was here sched.c:839:
error: conflicting types for
'sleep_on_timeout'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:598:
error: previous declaration of 'sleep_on_timeout' was here sched.c:210:
warning: 'reschedule_idle' declared `static' but never defined make[2]:
*** [sched.o] Error 1 make[2]: Leaving directory
`/usr/src/linux-2.4.27-pre2/kernel' make[1]: *** [first_rule] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.27-pre2/kernel'
make: *** [_dir_kernel] Error 2
[root@slack:/usr/src/linux-2.4.27-pre2#] 


This problem exist when i use GCC-3.4.0, GCC-3.2.3 doesn't cause it.



-- 
. JID: rmrmg(at)jabberpl(dot)org |   RMRMG   .
.           gg: #2311504         | signature .
.   mail: rmrmg(at)wp(dot)pl     |  version  .
.  registered Linux user 261525  |   0.0.3   .

[-- Attachment #2: .config.bz2 --]
[-- Type: application/octet-stream, Size: 4817 bytes --]

Re: Linux 2.4.27-pre2 (gcc-3.4.0)

[Rafał 'rmrmg' Roszak]

begin  Marc-Christian Petersen <m.c.p@kernel.linux-systeme.com> quote:

> On Tuesday 04 May 2004 21:19, Rafał 'rmrmg' Roszak wrote:
> 
> Hi Rafał
> 
> > make[2]: Entering directory `/usr/src/linux-2.4.27-pre2/kernel'
> > gcc -D__KERNEL__ -I/usr/src/linux-2.4.27-pre2/include -Wall
> > -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
> > -fno-common-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2
> > -march=athlon-nostdinc -iwithprefix include -DKBUILD_BASENAME=sched
> > -fno-omit-frame-pointer -c -o sched.o sched.c sched.c:213: error:
> > conflicting types for 'reschedule_idle' sched.c:210: error: previous
> > declaration of 'reschedule_idle' was here sched.c:213: error:
> > conflicting types for 'reschedule_idle' sched.c:210: error: previous
> > declaration of 'reschedule_idle' was here sched.c:371: error:
> > This problem exist when i use GCC-3.4.0, GCC-3.2.3 doesn't cause it.
> 
> Does the attached patch help there?
> 

Nope

make[2]: Entering directory `/usr/src/linux-2.4.27-pre2/kernel'
gcc -D__KERNEL__ -I/usr/src/linux-2.4.27-pre2/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon  
-nostdinc -iwithprefix include -DKBUILD_BASENAME=sched 
-fno-omit-frame-pointer -c -o sched.o sched.c sched.c:369: error:
conflicting types for
'wake_up_process'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:603:
error: previous declaration of 'wake_up_process' was here sched.c:369:
error: conflicting types for
'wake_up_process'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:603:
error: previous declaration of 'wake_up_process' was here sched.c:407:
error: conflicting types for
'schedule_timeout'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:148:
error: previous declaration of 'schedule_timeout' was here sched.c:407:
error: conflicting types for
'schedule_timeout'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:148:
error: previous declaration of 'schedule_timeout' was here sched.c:737:
error: conflicting types for
'__wake_up'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:595: error:
previous declaration of '__wake_up' was here sched.c:737: error:
conflicting types for
'__wake_up'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:595: error:
previous declaration of '__wake_up' was here sched.c:747: error:
conflicting types for
'__wake_up_sync'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:596:
error: previous declaration of '__wake_up_sync' was here sched.c:747:
error: conflicting types for
'__wake_up_sync'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:596:
error: previous declaration of '__wake_up_sync' was here sched.c:757:
error: conflicting types for
'complete'/usr/src/linux-2.4.27-pre2/include/linux/completion.h:31:
error: previous declaration of 'complete' was here sched.c:757: error:
conflicting types for
'complete'/usr/src/linux-2.4.27-pre2/include/linux/completion.h:31:
error: previous declaration of 'complete' was here sched.c:767: error:
conflicting types for
'wait_for_completion'/usr/src/linux-2.4.27-pre2/include/linux/completio
n.h:30: error: previous declaration of 'wait_for_completion' was here
sched.c:767: error: conflicting types for
'wait_for_completion'/usr/src/linux-2.4.27-pre2/include/linux/completio
n.h:30: error: previous declaration of 'wait_for_completion' was here
sched.c:802: error: conflicting types for
'interruptible_sleep_on'/usr/src/linux-2.4.27-pre2/include/linux/sched.
h:600: error: previous declaration of 'interruptible_sleep_on' was here
sched.c:802: error: conflicting types for
'interruptible_sleep_on'/usr/src/linux-2.4.27-pre2/include/linux/sched.
h:600: error: previous declaration of 'interruptible_sleep_on' was here
sched.c:813: error: conflicting types for
'interruptible_sleep_on_timeout'/usr/src/linux-2.4.27-pre2/include/linu
x/sched.h:601: error: previous declaration of
'interruptible_sleep_on_timeout' was here sched.c:813: error:
conflicting types for
'interruptible_sleep_on_timeout'/usr/src/linux-2.4.27-pre2/include/linu
x/sched.h:601: error: previous declaration of
'interruptible_sleep_on_timeout' was here sched.c:826: error:
conflicting types for
'sleep_on'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:597: error:
previous declaration of 'sleep_on' was here sched.c:826: error:
conflicting types for
'sleep_on'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:597: error:
previous declaration of 'sleep_on' was here sched.c:837: error:
conflicting types for
'sleep_on_timeout'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:598:
error: previous declaration of 'sleep_on_timeout' was here sched.c:837:
error: conflicting types for
'sleep_on_timeout'/usr/src/linux-2.4.27-pre2/include/linux/sched.h:598:
error: previous declaration of 'sleep_on_timeout' was here make[2]: ***
[sched.o] Error 1 make[2]: Leaving directory
`/usr/src/linux-2.4.27-pre2/kernel' make[1]: *** [first_rule] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.27-pre2/kernel'
make: *** [_dir_kernel] Error 2

-- 
. JID: rmrmg(at)jabberpl(dot)org |   RMRMG   .
.           gg: #2311504         | signature .
.   mail: rmrmg(at)wp(dot)pl     |  version  .
.  registered Linux user 261525  |   0.0.3   .

2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Adrian Bunk]

On Mon, May 03, 2004 at 08:09:12PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.27-pre1 to v2.4.27-pre2
> ============================================
>...
> Jeff Garzik:
>   o [TG3]: Dump NIC-specific statistics via ethtool
>...

This causes the following compile error:

<--  snip  -->

...
gcc-2.95 -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.27-pre2-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4   -nostdinc -iwithprefix include -DKBUILD_BASENAME=tg3  -c -o tg3.o tg3.c
tg3.c: In function `tg3_get_strings':
tg3.c:6267: warning: implicit declaration of function `WARN_ON'
...
        -o vmlinux
drivers/net/net.o(.text+0x60293): In function `tg3_get_strings':
: undefined reference to `WARN_ON'
make: *** [vmlinux] Error 1

<--  snip  -->

There's no WARN_ON in 2.4.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Marc-Christian Petersen]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

On Tuesday 04 May 2004 22:46, Adrian Bunk wrote:

Hi Adrian,

> drivers/net/net.o(.text+0x60293): In function `tg3_get_strings':
> : undefined reference to `WARN_ON'
> make: *** [vmlinux] Error 1
> There's no WARN_ON in 2.4.

yep. Either we backport WARN_ON ;) or simply do the attached.

ciao, Marc

[-- Attachment #2: 564_tg3-2.4.27-pre2-1.patch --]
[-- Type: text/x-diff, Size: 296 bytes --]

--- old/drivers/net/tg3.c	2004-05-04 14:30:22.000000000 +0200
+++ new/drivers/net/tg3.c	2004-05-04 14:49:58.000000000 +0200
@@ -51,6 +51,10 @@
 #define TG3_TSO_SUPPORT	0
 #endif
 
+#ifndef WARN_ON
+#define	WARN_ON(x)	do { } while (0)
+#endif
+
 #include "tg3.h"
 
 #define DRV_MODULE_NAME		"tg3"

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Jeff Garzik]

On Tue, May 04, 2004 at 10:53:11PM +0200, Marc-Christian Petersen wrote:
> On Tuesday 04 May 2004 22:46, Adrian Bunk wrote:
> 
> Hi Adrian,
> 
> > drivers/net/net.o(.text+0x60293): In function `tg3_get_strings':
> > : undefined reference to `WARN_ON'
> > make: *** [vmlinux] Error 1
> > There's no WARN_ON in 2.4.
> 
> yep. Either we backport WARN_ON ;) or simply do the attached.

I would rather add the simple patch to 2.4.x core, since tg3 isn't the
only driver that continues to be heavily used in 2.4, and thus will
continue to be actively maintained for a while...

	Jeff

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Eyal Lebedinsky]

Marc-Christian Petersen wrote:
> On Tuesday 04 May 2004 22:46, Adrian Bunk wrote:
> 
> Hi Adrian,
> 
> 
>>drivers/net/net.o(.text+0x60293): In function `tg3_get_strings':
>>: undefined reference to `WARN_ON'
>>make: *** [vmlinux] Error 1
>>There's no WARN_ON in 2.4.
> 
> 
> yep. Either we backport WARN_ON ;) or simply do the attached.
> 
> --- old/drivers/net/tg3.c	2004-05-04 14:30:22.000000000 +0200
> +++ new/drivers/net/tg3.c	2004-05-04 14:49:58.000000000 +0200
> @@ -51,6 +51,10 @@
>  #define TG3_TSO_SUPPORT	0
>  #endif
>  
> +#ifndef WARN_ON
> +#define	WARN_ON(x)	do { } while (0)
> +#endif

Related but off topic. Do people find the ab#define	WARN_ON(x)
a macro acceptable? The fact is that not mentioning 'x' means any
side-effects are not executed, meaning the author must take special
care when using this macro.

Maybe something like
	#define	WARN_ON(x)	do {(void)(x);} while (0)
which may still attract a warning about "stmt has no effect" (not
sure).

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[David S. Miller]

On Tue, 4 May 2004 16:56:59 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:

> > yep. Either we backport WARN_ON ;) or simply do the attached.
> 
> I would rather add the simple patch to 2.4.x core, since tg3 isn't the
> only driver that continues to be heavily used in 2.4, and thus will
> continue to be actively maintained for a while...

I agree, anyone cooking up a patch for this?

Re: Linux 2.4.27-pre2 (gcc-3.4.0)

[Rene Rebe]

Hi,

On: Tue, 4 May 2004 22:03:25 +0200,
    Rafa³ 'rmrmg' Roszak <rmrmg@wp.pl> wrote:
> begin  Marc-Christian Petersen <m.c.p@kernel.linux-systeme.com> quote:
> 
> > On Tuesday 04 May 2004 21:19, Rafa³ 'rmrmg' Roszak wrote:
> > 
> > Hi Rafa³
> > 
> > > make[2]: Entering directory `/usr/src/linux-2.4.27-pre2/kernel'
> > > gcc -D__KERNEL__ -I/usr/src/linux-2.4.27-pre2/include -Wall
> > > -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
> > > -fno-common-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2
> > > -march=athlon-nostdinc -iwithprefix include -DKBUILD_BASENAME=sched
> > > -fno-omit-frame-pointer -c -o sched.o sched.c sched.c:213: error:
> > > conflicting types for 'reschedule_idle' sched.c:210: error: previous
> > > declaration of 'reschedule_idle' was here sched.c:213: error:
> > > conflicting types for 'reschedule_idle' sched.c:210: error: previous
> > > declaration of 'reschedule_idle' was here sched.c:371: error:
> > > This problem exist when i use GCC-3.4.0, GCC-3.2.3 doesn't cause it.
> > 
> > Does the attached patch help there?

This patch should build a gcc-3.4 kernel with nearly everything
enabled on x86 and PowerPC (maybe more):

http://dl.rocklinux-consulting.de/oss/linux24/gcc340-fixes-v2.4.26-try3.patch

It is for 2.4.26 - but should apply mostly to 2.4.27-pre2, too - I
have not yet booted the resulting kernel, soo ....

Sincerely yours,
  René Rebe
    - ROCK Linux stable release maintainer

--  
René Rebe - Europe/Germany/Berlin
  rene@rocklinux.org rene@rocklinux-consulting.de
http://www.rocklinux.org http://www.rocklinux-consulting.de

Re: Linux 2.4.27-pre2 (gcc-3.4.0)

[Rafał 'rmrmg' Roszak]

begin  Rene Rebe <rene@rocklinux-consulting.de> quote:

> It is for 2.4.26 - but should apply mostly to 2.4.27-pre2, too - I
> have not yet booted the resulting kernel, soo ....

patching file kernel/sysctl.c
Hunk #1 succeeded at 879 (offset 3 lines).
Hunk #3 succeeded at 1133 (offset 3 lines).
patching file lib/brlock.c
patching file lib/crc32.c
patching file lib/rwsem.c
patching file lib/string.c
patching file mm/filemap.c
patching file mm/memory.c
patching file mm/page_alloc.c
Hunk #1 FAILED at 82.
Hunk #2 succeeded at 241 (offset 41 lines).
Hunk #4 succeeded at 295 (offset 41 lines).
Hunk #6 succeeded at 486 (offset 41 lines).
Hunk #8 succeeded at 509 (offset 41 lines).
1 out of 8 hunks FAILED -- saving rejects to file mm/page_alloc.c.rej

[root@slack:/usr/src/linux-2.4.27-pre2#] cat ./mm/page_alloc.c.rej 
***************
*** 82,88 ****
   */
  
  static void FASTCALL(__free_pages_ok (struct page *page, unsigned int
order));- static void __free_pages_ok (struct page *page, unsigned int
order)  {
  	unsigned long index, page_idx, mask, flags;
  	free_area_t *area;
--- 82,88 ----
   */
  
  static void FASTCALL(__free_pages_ok (struct page *page, unsigned int
order));+ static void fastcall __free_pages_ok (struct page *page,
unsigned int order)  {
  	unsigned long index, page_idx, mask, flags;
  	free_area_t *area;
[root@slack:/usr/src/linux-2.4.27-pre2#] 


make[2]: Entering directory `/usr/src/linux-2.4.27-pre2/mm'
gcc -D__KERNEL__ -I/usr/src/linux-2.4.27-pre2/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon
-fno-unit-at-a-time   -nostdinc -iwithprefix include
-DKBUILD_BASENAME=page_alloc  -DEXPORT_SYMTAB -c page_alloc.c
page_alloc.c:115: error: conflicting types for '__free_pages_ok'
page_alloc.c:51: error: previous declaration of '__free_pages_ok' was
here page_alloc.c:115: error: conflicting types for '__free_pages_ok'
page_alloc.c:51: error: previous declaration of '__free_pages_ok' was
here page_alloc.c:51: warning: '__free_pages_ok' used but never defined
make[2]: *** [page_alloc.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.4.27-pre2/mm'
make[1]: *** [first_rule] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.27-pre2/mm'
make: *** [_dir_mm] Error 2




-- 
. JID: rmrmg(at)jabberpl(dot)org |   RMRMG   .
.           gg: #2311504         | signature .
.   mail: rmrmg(at)wp(dot)pl     |  version  .
.  registered Linux user 261525  |   0.0.3   .

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Marc-Christian Petersen]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

On Wednesday 05 May 2004 05:18, David S. Miller wrote:

Hi Dave,

> > I would rather add the simple patch to 2.4.x core, since tg3 isn't the
> > only driver that continues to be heavily used in 2.4, and thus will
> > continue to be actively maintained for a while...

> I agree, anyone cooking up a patch for this?


Like this?

ciao, Marc

[-- Attachment #2: 2.4-WARN_ON.patch --]
[-- Type: text/x-diff, Size: 472 bytes --]

--- old/include/linux/kernel.h	2004-05-04 21:48:24.000000000 +0200
+++ new/include/linux/kernel.h	2004-05-05 10:53:32.000000000 +0200
@@ -196,4 +196,11 @@ struct sysinfo {
 
 #define BUG_ON(condition) do { if (unlikely((condition)!=0)) BUG(); } while(0)
 
+#define WARN_ON(condition) do { \
+	if (unlikely((condition)!=0)) { \
+		printk("Badness in %s at %s:%d\n", __FUNCTION__, __FILE__, __LINE__); \
+		dump_stack(); \
+	} \
+} while (0)
+
 #endif /* _LINUX_KERNEL_H */

Re: Linux 2.4.27-pre2 (gcc-3.4.0)

[Mikael Pettersson]

Rafa³ 'rmrmg' Roszak writes:
 > begin  Rene Rebe <rene@rocklinux-consulting.de> quote:
 > 
 > > It is for 2.4.26 - but should apply mostly to 2.4.27-pre2, too - I
 > > have not yet booted the resulting kernel, soo ....
 > 
 > patching file kernel/sysctl.c
 > Hunk #1 succeeded at 879 (offset 3 lines).
 > Hunk #3 succeeded at 1133 (offset 3 lines).
 > patching file lib/brlock.c
 > patching file lib/crc32.c
 > patching file lib/rwsem.c
 > patching file lib/string.c
 > patching file mm/filemap.c
 > patching file mm/memory.c
 > patching file mm/page_alloc.c
 > Hunk #1 FAILED at 82.
 > Hunk #2 succeeded at 241 (offset 41 lines).
 > Hunk #4 succeeded at 295 (offset 41 lines).
 > Hunk #6 succeeded at 486 (offset 41 lines).
 > Hunk #8 succeeded at 509 (offset 41 lines).
 > 1 out of 8 hunks FAILED -- saving rejects to file mm/page_alloc.c.rej

Read the archives, a solution has been available since last week. Use:
http://www.csd.uu.se/~mikpe/linux/patches/2.4/patch-gcc340-fixes-2.4.27-pre2

This has been throughly tested on i386 and x86_64 UP and SMP, and ppc UP,
although I have not verified drivers I don't use myself.

Re: Linux 2.4.27-pre2 (gcc-3.4.0)

[Rene Rebe]

Hi,

On: Wed, 5 May 2004 11:30:44 +0200,
    Mikael Pettersson <mikpe@csd.uu.se> wrote:
> Rafa³ 'rmrmg' Roszak writes:
>  > begin  Rene Rebe <rene@rocklinux-consulting.de> quote:
>  > 
>  > > It is for 2.4.26 - but should apply mostly to 2.4.27-pre2, too - I
>  > > have not yet booted the resulting kernel, soo ....
>  > 
>  > patching file kernel/sysctl.c
>  > Hunk #1 succeeded at 879 (offset 3 lines).
>  > Hunk #3 succeeded at 1133 (offset 3 lines).
>  > patching file lib/brlock.c
>  > patching file lib/crc32.c
>  > patching file lib/rwsem.c
>  > patching file lib/string.c
>  > patching file mm/filemap.c
>  > patching file mm/memory.c
>  > patching file mm/page_alloc.c
>  > Hunk #1 FAILED at 82.
>  > Hunk #2 succeeded at 241 (offset 41 lines).
>  > Hunk #4 succeeded at 295 (offset 41 lines).
>  > Hunk #6 succeeded at 486 (offset 41 lines).
>  > Hunk #8 succeeded at 509 (offset 41 lines).
>  > 1 out of 8 hunks FAILED -- saving rejects to file mm/page_alloc.c.rej
> 
> Read the archives, a solution has been available since last week. Use:
> http://www.csd.uu.se/~mikpe/linux/patches/2.4/patch-gcc340-fixes-2.4.27-pre2
> 
> This has been throughly tested on i386 and x86_64 UP and SMP, and ppc UP,
> although I have not verified drivers I don't use myself.

IIRC I based "my" patch uppon your's rediffed one chunk for 2.4.26 and
added some more driver fixes (since our build system automatically
enables as many as possible ...

So your patch alone should not fix this error - unfortunatly I'm
already fixing so many user-space apps for gcc-3.4 that I have not the
time to track 2.4.27 right now.

Sincerely yours,
  René Rebe
    - ROCK Linux stable release maintainer

--  
René Rebe - Europe/Germany/Berlin
  rene@rocklinux.org rene@rocklinux-consulting.de
http://www.rocklinux.org http://www.rocklinux-consulting.de

Re: Linux 2.4.27-pre2 (gcc-3.4.0)

[Mikael Pettersson]

Rene Rebe writes:
 > Hi,
 > 
 > On: Wed, 5 May 2004 11:30:44 +0200,
 >     Mikael Pettersson <mikpe@csd.uu.se> wrote:
 > > Rafa³ 'rmrmg' Roszak writes:
 > >  > begin  Rene Rebe <rene@rocklinux-consulting.de> quote:
 > >  > 
 > >  > > It is for 2.4.26 - but should apply mostly to 2.4.27-pre2, too - I
 > >  > > have not yet booted the resulting kernel, soo ....
 > >  > 
 > >  > patching file kernel/sysctl.c
 > >  > Hunk #1 succeeded at 879 (offset 3 lines).
 > >  > Hunk #3 succeeded at 1133 (offset 3 lines).
 > >  > patching file lib/brlock.c
 > >  > patching file lib/crc32.c
 > >  > patching file lib/rwsem.c
 > >  > patching file lib/string.c
 > >  > patching file mm/filemap.c
 > >  > patching file mm/memory.c
 > >  > patching file mm/page_alloc.c
 > >  > Hunk #1 FAILED at 82.
 > >  > Hunk #2 succeeded at 241 (offset 41 lines).
 > >  > Hunk #4 succeeded at 295 (offset 41 lines).
 > >  > Hunk #6 succeeded at 486 (offset 41 lines).
 > >  > Hunk #8 succeeded at 509 (offset 41 lines).
 > >  > 1 out of 8 hunks FAILED -- saving rejects to file mm/page_alloc.c.rej
 > > 
 > > Read the archives, a solution has been available since last week. Use:
 > > http://www.csd.uu.se/~mikpe/linux/patches/2.4/patch-gcc340-fixes-2.4.27-pre2
 > > 
 > > This has been throughly tested on i386 and x86_64 UP and SMP, and ppc UP,
 > > although I have not verified drivers I don't use myself.
 > 
 > IIRC I based "my" patch uppon your's rediffed one chunk for 2.4.26 and
 > added some more driver fixes (since our build system automatically
 > enables as many as possible ...

I see. That wasn't apparent from your previous message.

Anyway, 2.4.27-pre2 changed mm/page_alloc.c in a way that caused
the gcc340 fixes patch for 2.4.27-pre1 to fail. My updated patch
for -pre2 fixes this problem.

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[David S. Miller]

On Wed, 5 May 2004 10:57:06 +0200
Marc-Christian Petersen <m.c.p@kernel.linux-systeme.com> wrote:

> > I agree, anyone cooking up a patch for this?
> 
> 
> Like this?

Works for me, I'll push this to Marcelo thanks.

Re: Linux 2.4.27-pre2

[Eyal Lebedinsky]

Marcelo Tosatti wrote:
> Hi, 
> 
> Here goes the second pre release of 2.4.27 -pre2

While configuring I get:
     For AMD SHPC only: Use $HRT for resource/configuration (CONFIG_HOTPLUG_PCI_SHPC_PHPRM_LEGACY) [N/y/?] (NEW) ?

   Sorry, no help available for this option yet.

There are more. 2.4 is our stable branch and I expect all
help to be present - is this not the policy now?

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Adrian Bunk]

On Wed, May 05, 2004 at 09:44:06AM +1000, Eyal Lebedinsky wrote:
> Marc-Christian Petersen wrote:
> >On Tuesday 04 May 2004 22:46, Adrian Bunk wrote:
> >
> >Hi Adrian,
> >
> >
> >>drivers/net/net.o(.text+0x60293): In function `tg3_get_strings':
> >>: undefined reference to `WARN_ON'
> >>make: *** [vmlinux] Error 1
> >>There's no WARN_ON in 2.4.
> >
> >
> >yep. Either we backport WARN_ON ;) or simply do the attached.
> >
> >--- old/drivers/net/tg3.c	2004-05-04 14:30:22.000000000 +0200
> >+++ new/drivers/net/tg3.c	2004-05-04 14:49:58.000000000 +0200
> >@@ -51,6 +51,10 @@
> > #define TG3_TSO_SUPPORT	0
> > #endif
> > 
> >+#ifndef WARN_ON
> >+#define	WARN_ON(x)	do { } while (0)
> >+#endif
> 
> Related but off topic. Do people find the ab#define	WARN_ON(x)
> a macro acceptable? The fact is that not mentioning 'x' means any
> side-effects are not executed, meaning the author must take special
> care when using this macro.
>...

Do not use code with side effects in BUG_ON and WARN_ON.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: Linux 2.4.27-pre2

[Marcelo Tosatti]

On Thu, May 06, 2004 at 09:50:07AM +1000, Eyal Lebedinsky wrote:
> Marcelo Tosatti wrote:
> >Hi, 
> >
> >Here goes the second pre release of 2.4.27 -pre2
> 
> While configuring I get:
>     For AMD SHPC only: Use $HRT for resource/configuration 
>     (CONFIG_HOTPLUG_PCI_SHPC_PHPRM_LEGACY) [N/y/?] (NEW) ?
> 
>   Sorry, no help available for this option yet.
> 
> There are more. 2.4 is our stable branch and I expect all
> help to be present - is this not the policy now?

Eyal,

Right, there should be basic documentation available.

Greg?

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[H. Peter Anvin]

Followup to:  <20040506121302.GI9636@fs.tum.de>
By author:    Adrian Bunk <bunk@fs.tum.de>
In newsgroup: linux.dev.kernel
> > >
> > >yep. Either we backport WARN_ON ;) or simply do the attached.
> > >
> > >--- old/drivers/net/tg3.c	2004-05-04 14:30:22.000000000 +0200
> > >+++ new/drivers/net/tg3.c	2004-05-04 14:49:58.000000000 +0200
> > >@@ -51,6 +51,10 @@
> > > #define TG3_TSO_SUPPORT	0
> > > #endif
> > > 
> > >+#ifndef WARN_ON
> > >+#define	WARN_ON(x)	do { } while (0)
> > >+#endif
> > 
> > Related but off topic. Do people find the ab#define	WARN_ON(x)
> > a macro acceptable? The fact is that not mentioning 'x' means any
> > side-effects are not executed, meaning the author must take special
> > care when using this macro.
> >...
> 
> Do not use code with side effects in BUG_ON and WARN_ON.
> 

Why not use the much simpler:

#ifndef WARN_ON
# define WARN_ON(x) ((void)(x))
#endif

Preserves side effects and everything.

	-hpa

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Adrian Bunk]

On Wed, May 12, 2004 at 12:07:44AM +0000, H. Peter Anvin wrote:
> Followup to:  <20040506121302.GI9636@fs.tum.de>
> By author:    Adrian Bunk <bunk@fs.tum.de>
> In newsgroup: linux.dev.kernel
> > > >
> > > >yep. Either we backport WARN_ON ;) or simply do the attached.
> > > >
> > > >--- old/drivers/net/tg3.c	2004-05-04 14:30:22.000000000 +0200
> > > >+++ new/drivers/net/tg3.c	2004-05-04 14:49:58.000000000 +0200
> > > >@@ -51,6 +51,10 @@
> > > > #define TG3_TSO_SUPPORT	0
> > > > #endif
> > > > 
> > > >+#ifndef WARN_ON
> > > >+#define	WARN_ON(x)	do { } while (0)
> > > >+#endif
> > > 
> > > Related but off topic. Do people find the ab#define	WARN_ON(x)
> > > a macro acceptable? The fact is that not mentioning 'x' means any
> > > side-effects are not executed, meaning the author must take special
> > > care when using this macro.
> > >...
> > 
> > Do not use code with side effects in BUG_ON and WARN_ON.
> > 
> 
> Why not use the much simpler:
> 
> #ifndef WARN_ON
> # define WARN_ON(x) ((void)(x))
> #endif
> 
> Preserves side effects and everything.

AFAIR, the -tiny tree already implements some kind of empty 
BUG/PAGE_BUG/WARN_ON macros.

When optimizing for size that way, your suggestion would result in 
bigger code.

And after a quick view, I haven't seen any WARN_ON users in 2.6 that
seem to rely on side effects.

> 	-hpa

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[H. Peter Anvin]

Adrian Bunk wrote:
>> 
> AFAIR, the -tiny tree already implements some kind of empty 
> BUG/PAGE_BUG/WARN_ON macros.
> 
> When optimizing for size that way, your suggestion would result in 
> bigger code.
> 

?!?!?!?!?!

If there are no side effects, my suggestion produces zero code.

> And after a quick view, I haven't seen any WARN_ON users in 2.6 that
> seem to rely on side effects.

Then there should be no size difference, either.

	-hpa

Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4

[Adrian Bunk]

On Thu, May 13, 2004 at 04:03:15PM -0700, H. Peter Anvin wrote:
> Adrian Bunk wrote:
> >>
> >AFAIR, the -tiny tree already implements some kind of empty 
> >BUG/PAGE_BUG/WARN_ON macros.
> >
> >When optimizing for size that way, your suggestion would result in 
> >bigger code.
> >
> 
> ?!?!?!?!?!
> 
> If there are no side effects, my suggestion produces zero code.
> 
> >And after a quick view, I haven't seen any WARN_ON users in 2.6 that
> >seem to rely on side effects.
> 
> Then there should be no size difference, either.

Ah thanks, now I do understand it.

> 	-hpa

Thanks
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

[2.4 patch] hotplug: add missing Configure.help entries

[Adrian Bunk]

On Mon, May 03, 2004 at 08:09:12PM -0300, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.27-pre1 to v2.4.27-pre2
> ============================================
>...
> Dely Sy:
>   o SHPC and PCI Express hot-plug drivers for 2.4 kernel
>...

People seem to tend to forget Configure.help entries for new drivers...

Below is a patch to add Configure.help entries based on the entries 
in 2.6 .

Please apply
Adrian

--- linux-2.4.27-pre3-full/Documentation/Configure.help.old	2004-05-19 20:04:49.000000000 +0200
+++ linux-2.4.27-pre3-full/Documentation/Configure.help	2004-05-19 20:10:22.000000000 +0200
@@ -4300,6 +4300,26 @@
   The module will be called acpiphp.o. If you want to compile it
   as a module, say M here and read <file:Documentation/modules.txt>.
 
+CONFIG_HOTPLUG_PCI_SHPC
+  Say Y here if you have a motherboard with a SHPC PCI Hotplug
+  controller.
+
+CONFIG_HOTPLUG_PCI_SHPC_POLL_EVENT_MODE
+  Say Y here if you want to use the polling mechanism for hot-plug 
+  events for early platform testing.
+
+CONFIG_HOTPLUG_PCI_SHPC_PHPRM_LEGACY
+  Say Y here for AMD SHPC. You have to select this option if you are 
+  using this driver on platform with AMD SHPC.
+
+CONFIG_HOTPLUG_PCI_PCIE
+  Say Y here if you have a motherboard that supports PCI Express Native
+  Hotplug
+
+CONFIG_HOTPLUG_PCI_PCIE_POLL_EVENT_MODE
+  Say Y here if you want to use the polling mechanism for hot-plug 
+  events for early platform testing.
+
 MCA support
 CONFIG_MCA
   MicroChannel Architecture is found in some IBM PS/2 machines and