LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.6-mm3: USB console.c doesn't compile
Date: Mon, 17 May 2004 09:32:07 -0700	[thread overview]
Message-ID: <20040517163207.GB28629@kroah.com> (raw)
In-Reply-To: <20040516183849.GO22742@fs.tum.de>

On Sun, May 16, 2004 at 08:38:49PM +0200, Adrian Bunk wrote:
> The following compile error comes from Linus' tree:
> 
> <--  snip  -->
> 
> ...
>   CC      drivers/usb/serial/console.o
> drivers/usb/serial/console.c: In function `usb_console_setup':
> drivers/usb/serial/console.c:140: warning: implicit declaration of function `serial_paranoia_check'
> ...
>   LD      .tmp_vmlinux1
> drivers/built-in.o(.init.text+0x698c8): In function `usb_console_setup':
> : undefined reference to `serial_paranoia_check'
> make: *** [.tmp_vmlinux1] Error 1

Oops, forgot that one, sorry.  Here's a patch that fixes it, and I'll
forward it on to Linus later today.

thanks,

greg k-h


diff -Nru a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
--- a/drivers/usb/serial/console.c	Mon May 17 09:31:11 2004
+++ b/drivers/usb/serial/console.c	Mon May 17 09:31:11 2004
@@ -137,7 +137,7 @@
 
 	/* grab the first serial port that happens to be connected */
 	serial = usb_serial_get_by_index(0);
-	if (serial_paranoia_check (serial, __FUNCTION__)) {
+	if (serial == NULL) {
 		/* no device is connected yet, sorry :( */
 		err ("No USB device connected to ttyUSB0");
 		return -ENODEV;

  reply	other threads:[~2004-05-17 16:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-16  9:55 2.6.6-mm3 Andrew Morton
2004-05-16 10:35 ` 2.6.6-mm3 Prakash K. Cheemplavam
2004-05-16 11:00   ` 2.6.6-mm3 Gene Heskett
2004-05-16 16:29   ` 2.6.6-mm3 Andrew Morton
2004-05-16 18:38 ` 2.6.6-mm3: USB console.c doesn't compile Adrian Bunk
2004-05-17 16:32   ` Greg KH [this message]
2004-05-16 20:15 ` [patch] 2.6.6-mm3: more PC9800 removal Adrian Bunk
2004-05-16 20:35 ` [patch] 2.6.6-mm3: remove PC9800 from should-fix Adrian Bunk
2004-05-17 11:52 ` 2.6.6-mm3 Eric W. Biederman
2004-05-17 12:57 ` 2.6.6-mm3 Aristeu Sergio Rozanski Filho
2004-05-17 15:06   ` 2.6.6-mm3 Robert Picco
2004-05-17 15:51     ` 2.6.6-mm3 Aristeu Sergio Rozanski Filho
2004-05-17 13:09 ` Scroll wheel on PS/2 Logitech MouseMan Wheel no longer works (was Re: 2.6.6-mm3) Sean Neakums
2004-05-17 18:10   ` Dmitry Torokhov
     [not found]     ` <6u4qqejiny.fsf@zork.zork.net>
     [not found]       ` <200405191256.32335.dtor_core@ameritech.net>
2004-05-20  7:49         ` Sean Neakums
2004-05-26  3:40           ` Dmitry Torokhov
2004-06-06 17:49             ` Vojtech Pavlik
2004-05-17 16:14 ` 2.6.6-mm3 Tom Rini
2004-05-17 16:30   ` 2.6.6-mm3 Robert Picco
2004-05-17 16:38     ` 2.6.6-mm3 Tom Rini
2004-05-17 17:56       ` 2.6.6-mm3 Tom Rini
2004-05-18 13:45         ` [Kgdb-bugreport] 2.6.6-mm3 Amit S. Kale
2004-05-17 17:20 ` 2.6.6-mm3 Chris Wright
2004-05-17 17:42 ` [PATCH][PPC32] Update Motorola LoPEC and Sandpoint defconfigs Tom Rini
2004-05-17 17:54   ` [PATCH][PPC32] Remove 'mem_pieces_append' Tom Rini
2004-05-17 18:06     ` [PATCH][PPC32] Some fixes for 'make O=...' Tom Rini
2004-05-18  2:08 ` 2.6.6-mm3: i810 agpgart module can't be initialized Clemens Schwaighofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040517163207.GB28629@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: 2.6.6-mm3: USB console.c doesn'\''t compile' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).