LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Trond Myklebust <trond.myklebust@fys.uio.no>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: RPC request reserved 0 but used 96
Date: Tue, 18 May 2004 13:03:43 +0200	[thread overview]
Message-ID: <20040518110342.GE30348@suse.de> (raw)
In-Reply-To: <20040518040613.GB10633@fieldses.org>

On Tue, May 18 2004, J. Bruce Fields wrote:
> On Sat, May 15, 2004 at 12:36:51PM +0200, Jens Axboe wrote:
> > 2.6.6-BK with shares exported sync show the same behaviour. I get:
> > 
> > RPC request reserved 0 but used 32900
> > RPC request reserved 0 but used 32900
> > RPC request reserved 0 but used 96
> 
> Does this end the messages?
> 
> --Bruce Fields
> 
> svc_recv may call svc_sock_release before rqstp->rq_res is initialized.
> 
>  net/sunrpc/svcsock.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> diff -puN net/sunrpc/svcsock.c~svc_reserve_debugging net/sunrpc/svcsock.c
> --- linux-2.6.6/net/sunrpc/svcsock.c~svc_reserve_debugging	2004-05-17 23:46:51.000000000 -0400
> +++ linux-2.6.6-bfields/net/sunrpc/svcsock.c	2004-05-17 23:50:54.000000000 -0400
> @@ -1255,6 +1255,7 @@ svc_recv(struct svc_serv *serv, struct s
>  
>  	/* No data, incomplete (TCP) read, or accept() */
>  	if (len == 0 || len == -EAGAIN) {
> +		rqstp->rq_res.len = 0;
>  		svc_sock_release(rqstp);
>  		return -EAGAIN;
>  	}

Seems to have fixed it, at least I haven't seen any messages of this
sort since applying the patch and switching back to nfs over tcp.
Thanks!

-- 
Jens Axboe


      parent reply	other threads:[~2004-05-18 11:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-15  8:38 Jens Axboe
2004-05-15  8:58 ` Jens Axboe
2004-05-15 10:36   ` Jens Axboe
     [not found]     ` <20040518040613.GB10633@fieldses.org>
2004-05-18 11:03       ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040518110342.GE30348@suse.de \
    --to=axboe@suse.de \
    --cc=akpm@osdl.org \
    --cc=bfields@fieldses.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    --subject='Re: RPC request reserved 0 but used 96' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).