LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Trivial Comment Patch: 2.6.6-mm3
@ 2004-05-18 13:08 Danny Cox
  2004-05-18 20:07 ` Chris Wedgwood
  0 siblings, 1 reply; 3+ messages in thread
From: Danny Cox @ 2004-05-18 13:08 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

Andrew,

	This fixes a comment in the stack overflow check that's wrong with 4K
stacks.

	Sorry to attach it, but Evolution screws up the lines if it's inline.

	Thanks!

-- 
Daniel S. Cox
Electronic Commerce Systems

[-- Attachment #2: 4kstack_comment_fix.patch --]
[-- Type: text/plain, Size: 335 bytes --]

--- irq.c.orig	2004-05-18 08:53:05.363390440 -0400
+++ irq.c	2004-05-18 08:53:25.052755701 -0400
@@ -431,7 +431,7 @@
 	irq_enter();
 
 #ifdef CONFIG_DEBUG_STACKOVERFLOW
-	/* Debugging check for stack overflow: is there less than 1KB free? */
+	/* Debugging check for stack overflow: is there less than 512B free? */
 	{
 		long esp;
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Trivial Comment Patch: 2.6.6-mm3
  2004-05-18 13:08 Trivial Comment Patch: 2.6.6-mm3 Danny Cox
@ 2004-05-18 20:07 ` Chris Wedgwood
  2004-05-19 11:18   ` Danny Cox
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Wedgwood @ 2004-05-18 20:07 UTC (permalink / raw)
  To: Danny Cox; +Cc: linux-kernel

On Tue, May 18, 2004 at 09:08:57AM -0400, Danny Cox wrote:

> This fixes a comment in the stack overflow check that's wrong with
> 4K stacks.

>  #ifdef CONFIG_DEBUG_STACKOVERFLOW
> -	/* Debugging check for stack overflow: is there less than 1KB free? */
> +	/* Debugging check for stack overflow: is there less than 512B free? */
>  	{
>  		long esp;

akpm, how about just yank the line? the comment's sanity depends on a
CONFIG option and also a value in another file from a far off land.


  --cw

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Trivial Comment Patch: 2.6.6-mm3
  2004-05-18 20:07 ` Chris Wedgwood
@ 2004-05-19 11:18   ` Danny Cox
  0 siblings, 0 replies; 3+ messages in thread
From: Danny Cox @ 2004-05-19 11:18 UTC (permalink / raw)
  To: Chris Wedgwood; +Cc: Linux Kernel Mailing List

Chris,

On Tue, 2004-05-18 at 16:07, Chris Wedgwood wrote:
> On Tue, May 18, 2004 at 09:08:57AM -0400, Danny Cox wrote:
> 
> > This fixes a comment in the stack overflow check that's wrong with
> > 4K stacks.
> 
> >  #ifdef CONFIG_DEBUG_STACKOVERFLOW
> > -	/* Debugging check for stack overflow: is there less than 1KB free? */
> > +	/* Debugging check for stack overflow: is there less than 512B free? */
> >  	{
> >  		long esp;
> 
> akpm, how about just yank the line? the comment's sanity depends on a
> CONFIG option and also a value in another file from a far off land.

	IMHO, I'd say keep the line, but remove the offensive part (everything
past the ':', inclusive).

-- 
Daniel S. Cox
Electronic Commerce Systems


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-05-19 11:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-18 13:08 Trivial Comment Patch: 2.6.6-mm3 Danny Cox
2004-05-18 20:07 ` Chris Wedgwood
2004-05-19 11:18   ` Danny Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).