LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use idr_get_new to allocate a bus id in drivers/i2c/i2c-core.c
Date: Wed, 19 May 2004 00:07:01 -0700	[thread overview]
Message-ID: <20040519070701.GB18660@kroah.com> (raw)
In-Reply-To: <20040516091312.GA2052@tnn.net>

On Sun, May 16, 2004 at 12:13:13PM +0300, Faik Uygur wrote:
> On Sat, 15 May 2004, Andrew Morton wrote:
> 
> > The IDR interface is a bit cumbersome.  Even though you called
> > idr_pre_get(), there's no guarantee that the memory which it preallocated
> > is still present when you call idr_get_new().
> 
> Thanks for the correction.
> 
> > Is the kernel likely to ever have so many bus IDs that we actually need
> > this patch?  Or do you specifically want first-fit-from-zero for some
> > reason?
> 
> Actually there is no special need for this. It is just what i think would
> be the expected behaviour. There was a thread two weeks ago about this issue:
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=108370586601550&w=2
> 
> here is the updated patch:

Nice, thanks, I've applied this to my trees.  I tried doing this same
patch a while ago, but missed the masking off the upper bits trick, and
was wondering why my results were so strange...

thanks again,

greg k-h

      parent reply	other threads:[~2004-05-19  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-15 22:26 Faik Uygur
2004-05-15 23:58 ` Andrew Morton
2004-05-16  9:13   ` Faik Uygur
2004-05-16  9:36     ` Andrew Morton
2004-05-19  7:07     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040519070701.GB18660@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] use idr_get_new to allocate a bus id in drivers/i2c/i2c-core.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).