LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: davidm@hpl.hp.com
Cc: hch@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixing sendfile on 64bit architectures
Date: Thu, 20 May 2004 14:56:58 -0700	[thread overview]
Message-ID: <20040520145658.3a7bf7df.akpm@osdl.org> (raw)
In-Reply-To: <16557.4709.694265.314748@napali.hpl.hp.com>

David Mosberger <davidm@napali.hpl.hp.com> wrote:
>
> >>>>> On Thu, 20 May 2004 20:35:32 +0100, Christoph Hellwig <hch@infradead.org> said:
> 
>   Christoph> IMHO this is exactly the wrong way around.  It should be
>   Christoph> __ARCH_WANT_* or something like that so new architectures
>   Christoph> don't carry the old garbage around by default.  There's
>   Christoph> far too many new architectures keeping old syscalls by
>   Christoph> accident.
> 
> Feel free to do that.  I was trying not to break anything and I'm
> _certain_ I would have gotten it wrong if I had reversed the sense.
> 
> I think the current patch is an improvement, so unless someone comes
> up with something better, I'd like to see it applied.

I do agree that ARCH_WANT_FOO is easier to understand and more idiomatic.

An alternative might be to remove all the ifdefs, build with
-ffunction-sections and let the linker drop any unreferenced code...

  reply	other threads:[~2004-05-20 21:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <26879984$108499340940abaf81679ba6.07529629@config22.schlund.de>
     [not found] ` <16556.19979.951743.994128@napali.hpl.hp.com>
     [not found]   ` <20040519234106.52b6db78.davem@redhat.com>
     [not found]     ` <16556.65456.624986.552865@napali.hpl.hp.com>
     [not found]       ` <20040520120645.3accf048.akpm@osdl.org>
2004-05-20 19:26         ` David Mosberger
2004-05-20 19:35           ` Christoph Hellwig
2004-05-20 20:17             ` David Mosberger
2004-05-20 21:56               ` Andrew Morton [this message]
2004-05-20 22:00                 ` David Mosberger
2004-05-20 22:09                 ` David Mosberger
2004-05-20 23:30                   ` Andrew Morton
2004-05-20 23:44                     ` David Mosberger
2004-05-21  0:17                       ` Spam: " Andrew Morton
2004-05-21  0:25                         ` David Mosberger
2004-05-20 22:10                 ` Jesse Barnes
2004-05-20 22:25                   ` Andrew Morton
2004-05-20 22:32                     ` David Mosberger
2004-05-20 22:33                     ` Jesse Barnes
     [not found] <1Y1yE-4Lz-7@gated-at.bofh.it>
     [not found] ` <1Y1yF-4Lz-9@gated-at.bofh.it>
     [not found]   ` <1Y1yF-4Lz-11@gated-at.bofh.it>
     [not found]     ` <1Y1yF-4Lz-13@gated-at.bofh.it>
     [not found]       ` <1Y1yF-4Lz-15@gated-at.bofh.it>
     [not found]         ` <1Y1yE-4Lz-5@gated-at.bofh.it>
     [not found]           ` <1Y1yJ-4Lz-37@gated-at.bofh.it>
     [not found]             ` <1Y2l5-5rr-5@gated-at.bofh.it>
     [not found]               ` <1Y3Ki-6x6-35@gated-at.bofh.it>
2004-05-21  9:01                 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040520145658.3a7bf7df.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=davidm@hpl.hp.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] fixing sendfile on 64bit architectures' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).