Re: [PATCH] fixing sendfile on 64bit architectures

[Andrew Morton <akpm@osdl.org>]

David Mosberger <davidm@napali.hpl.hp.com> wrote:
>
> Here is what the reversed-sense patch looks like (mostly autogenerated
> via a script).

ppc64 is happy.

x86_64 is not happy:

fs/stat.c:287: warning: `struct stat64' declared inside parameter list
fs/stat.c:287: warning: its scope is only this definition or declaration, which is probably not what you want
fs/stat.c: In function `cp_new_stat64':
fs/stat.c:289: storage size of `tmp' isn't known
fs/stat.c:291: sizeof applied to an incomplete type
fs/stat.c:289: warning: unused variable `tmp'
fs/stat.c: At top level:
fs/stat.c:322: warning: `struct stat64' declared inside parameter list
fs/stat.c: In function `sys_stat64':
fs/stat.c:328: warning: passing arg 2 of `cp_new_stat64' from incompatible pointer type
fs/stat.c: At top level:
fs/stat.c:332: warning: `struct stat64' declared inside parameter list
fs/stat.c: In function `sys_lstat64':
fs/stat.c:338: warning: passing arg 2 of `cp_new_stat64' from incompatible pointer type
fs/stat.c: At top level:
fs/stat.c:342: warning: `struct stat64' declared inside parameter list
fs/stat.c: In function `sys_fstat64':
fs/stat.c:348: warning: passing arg 2 of `cp_new_stat64' from incompatible pointer type

sparc64 is not happy:

fs/stat.c:115: warning: `struct __old_kernel_stat' declared inside parameter list
fs/stat.c:115: warning: its scope is only this definition or declaration, which is probably not what you want
fs/stat.c: In function `cp_old_stat':
fs/stat.c:118: error: storage size of `tmp' isn't known
fs/stat.c:129: error: invalid application of `sizeof' to an incomplete type
fs/stat.c:129: error: invalid application of `sizeof' to an incomplete type
fs/stat.c:129: error: invalid application of `sizeof' to an incomplete type
fs/stat.c:129: error: invalid application of `sizeof' to an incomplete type
fs/stat.c:129: error: invalid application of `sizeof' to an incomplete type
fs/stat.c:118: warning: unused variable `tmp'
fs/stat.c: At top level:
fs/stat.c:148: warning: `struct __old_kernel_stat' declared inside parameter list
fs/stat.c: In function `sys_stat':
fs/stat.c:154: warning: passing arg 2 of `cp_old_stat' from incompatible pointer type
fs/stat.c: At top level:
fs/stat.c:158: warning: `struct __old_kernel_stat' declared inside parameter list
fs/stat.c: In function `sys_lstat':
fs/stat.c:164: warning: passing arg 2 of `cp_old_stat' from incompatible pointer type
fs/stat.c: At top level:
fs/stat.c:168: warning: `struct __old_kernel_stat' declared inside parameter list
fs/stat.c: In function `sys_fstat':
fs/stat.c:174: warning: passing arg 2 of `cp_old_stat' from incompatible pointer type