LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* ramfs lfs limit
@ 2004-05-21 7:37 Andrea Arcangeli
2004-05-21 7:41 ` Jeff Garzik
2004-05-21 8:11 ` Ingo Molnar
0 siblings, 2 replies; 4+ messages in thread
From: Andrea Arcangeli @ 2004-05-21 7:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Hi Andrew,
this fixes the 2G limit on ramfs
--- sles/fs/ramfs/inode.c.~1~ 2003-10-31 05:54:29.000000000 +0100
+++ sles/fs/ramfs/inode.c 2004-05-21 07:55:07.394369104 +0200
@@ -181,6 +181,7 @@ static int ramfs_fill_super(struct super
struct inode * inode;
struct dentry * root;
+ sb->s_maxbytes = MAX_LFS_FILESIZE;
sb->s_blocksize = PAGE_CACHE_SIZE;
sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
sb->s_magic = RAMFS_MAGIC;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ramfs lfs limit
2004-05-21 7:37 ramfs lfs limit Andrea Arcangeli
@ 2004-05-21 7:41 ` Jeff Garzik
2004-05-21 8:56 ` Andrea Arcangeli
2004-05-21 8:11 ` Ingo Molnar
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2004-05-21 7:41 UTC (permalink / raw)
To: Andrea Arcangeli; +Cc: Andrew Morton, linux-kernel
On Fri, May 21, 2004 at 09:37:02AM +0200, Andrea Arcangeli wrote:
> Hi Andrew,
>
> this fixes the 2G limit on ramfs
>
> --- sles/fs/ramfs/inode.c.~1~ 2003-10-31 05:54:29.000000000 +0100
> +++ sles/fs/ramfs/inode.c 2004-05-21 07:55:07.394369104 +0200
> @@ -181,6 +181,7 @@ static int ramfs_fill_super(struct super
> struct inode * inode;
> struct dentry * root;
>
> + sb->s_maxbytes = MAX_LFS_FILESIZE;
Why don't we change the default in alloc_super() instead?
We should not default to "lame" :)
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ramfs lfs limit
2004-05-21 7:37 ramfs lfs limit Andrea Arcangeli
2004-05-21 7:41 ` Jeff Garzik
@ 2004-05-21 8:11 ` Ingo Molnar
1 sibling, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2004-05-21 8:11 UTC (permalink / raw)
To: Andrea Arcangeli; +Cc: Andrew Morton, linux-kernel
* Andrea Arcangeli <andrea@suse.de> wrote:
> Hi Andrew,
>
> this fixes the 2G limit on ramfs
>
> --- sles/fs/ramfs/inode.c.~1~ 2003-10-31 05:54:29.000000000 +0100
> +++ sles/fs/ramfs/inode.c 2004-05-21 07:55:07.394369104 +0200
> @@ -181,6 +181,7 @@ static int ramfs_fill_super(struct super
> struct inode * inode;
> struct dentry * root;
>
> + sb->s_maxbytes = MAX_LFS_FILESIZE;
> sb->s_blocksize = PAGE_CACHE_SIZE;
> sb->s_blocksize_bits = PAGE_CACHE_SHIFT;
> sb->s_magic = RAMFS_MAGIC;
yep - fixed this for RHEL3 half a year ago but forgot about it. It works
well, people are using multi-GB ramfs instances without problems.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ramfs lfs limit
2004-05-21 7:41 ` Jeff Garzik
@ 2004-05-21 8:56 ` Andrea Arcangeli
0 siblings, 0 replies; 4+ messages in thread
From: Andrea Arcangeli @ 2004-05-21 8:56 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, linux-kernel
On Fri, May 21, 2004 at 03:41:12AM -0400, Jeff Garzik wrote:
> On Fri, May 21, 2004 at 09:37:02AM +0200, Andrea Arcangeli wrote:
> > Hi Andrew,
> >
> > this fixes the 2G limit on ramfs
> >
> > --- sles/fs/ramfs/inode.c.~1~ 2003-10-31 05:54:29.000000000 +0100
> > +++ sles/fs/ramfs/inode.c 2004-05-21 07:55:07.394369104 +0200
> > @@ -181,6 +181,7 @@ static int ramfs_fill_super(struct super
> > struct inode * inode;
> > struct dentry * root;
> >
> > + sb->s_maxbytes = MAX_LFS_FILESIZE;
>
>
> Why don't we change the default in alloc_super() instead?
>
> We should not default to "lame" :)
we default to "lame" to protect the lame filesystems from
malfunctioning ;), this was extremely intentional in the early days, now
less but it's still intentional. We may change that someday but
defaulting to safe when there's no downside doesn't sound that urgent to
change.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-05-21 8:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-21 7:37 ramfs lfs limit Andrea Arcangeli
2004-05-21 7:41 ` Jeff Garzik
2004-05-21 8:56 ` Andrea Arcangeli
2004-05-21 8:11 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).