LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()
@ 2004-05-21 19:59 Arthur Othieno
2004-05-21 20:04 ` Jeff Garzik
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arthur Othieno @ 2004-05-21 19:59 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
Hi,
We're prematurely pampering the request queue before
checking whether it was indeed allocated successfully.
Against 2.6.6. Thanks.
floppy.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/block/floppy.c 2004-05-20 23:48:04.000000000 +0200
+++ b/drivers/block/floppy.c 2004-05-21 21:29:33.000000000 +0200
@@ -4271,11 +4271,11 @@
goto out;
floppy_queue = blk_init_queue(do_fd_request, &floppy_lock);
- blk_queue_max_sectors(floppy_queue, 64);
if (!floppy_queue) {
err = -ENOMEM;
goto fail_queue;
}
+ blk_queue_max_sectors(floppy_queue, 64);
blk_register_region(MKDEV(FLOPPY_MAJOR, 0), 256, THIS_MODULE,
floppy_find, NULL, NULL);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()
2004-05-21 19:59 [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors() Arthur Othieno
@ 2004-05-21 20:04 ` Jeff Garzik
2004-05-21 20:10 ` Zwane Mwaikambo
2004-05-21 20:33 ` Luiz Fernando N. Capitulino
2 siblings, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2004-05-21 20:04 UTC (permalink / raw)
To: Arthur Othieno; +Cc: akpm, linux-kernel
Arthur Othieno wrote:
> Hi,
>
> We're prematurely pampering the request queue before
> checking whether it was indeed allocated successfully.
>
> Against 2.6.6. Thanks.
>
>
> floppy.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/block/floppy.c 2004-05-20 23:48:04.000000000 +0200
> +++ b/drivers/block/floppy.c 2004-05-21 21:29:33.000000000 +0200
> @@ -4271,11 +4271,11 @@
> goto out;
>
> floppy_queue = blk_init_queue(do_fd_request, &floppy_lock);
> - blk_queue_max_sectors(floppy_queue, 64);
> if (!floppy_queue) {
> err = -ENOMEM;
> goto fail_queue;
> }
> + blk_queue_max_sectors(floppy_queue, 64);
Good catch...
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()
2004-05-21 19:59 [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors() Arthur Othieno
2004-05-21 20:04 ` Jeff Garzik
@ 2004-05-21 20:10 ` Zwane Mwaikambo
2004-05-21 20:33 ` Luiz Fernando N. Capitulino
2 siblings, 0 replies; 5+ messages in thread
From: Zwane Mwaikambo @ 2004-05-21 20:10 UTC (permalink / raw)
To: Arthur Othieno; +Cc: akpm, linux-kernel
On Fri, 21 May 2004, Arthur Othieno wrote:
> We're prematurely pampering the request queue before
> checking whether it was indeed allocated successfully.
>
> Against 2.6.6. Thanks.
>
>
> floppy.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/block/floppy.c 2004-05-20 23:48:04.000000000 +0200
> +++ b/drivers/block/floppy.c 2004-05-21 21:29:33.000000000 +0200
> @@ -4271,11 +4271,11 @@
> goto out;
>
> floppy_queue = blk_init_queue(do_fd_request, &floppy_lock);
> - blk_queue_max_sectors(floppy_queue, 64);
> if (!floppy_queue) {
> err = -ENOMEM;
> goto fail_queue;
> }
> + blk_queue_max_sectors(floppy_queue, 64);
>
> blk_register_region(MKDEV(FLOPPY_MAJOR, 0), 256, THIS_MODULE,
> floppy_find, NULL, NULL);
ooh nice.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()
2004-05-21 19:59 [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors() Arthur Othieno
2004-05-21 20:04 ` Jeff Garzik
2004-05-21 20:10 ` Zwane Mwaikambo
@ 2004-05-21 20:33 ` Luiz Fernando N. Capitulino
2004-05-21 20:51 ` Arthur Othieno
2 siblings, 1 reply; 5+ messages in thread
From: Luiz Fernando N. Capitulino @ 2004-05-21 20:33 UTC (permalink / raw)
To: Arthur Othieno; +Cc: akpm, linux-kernel
Hi Arthur,
Em Fri, May 21, 2004 at 09:59:34PM +0200, Arthur Othieno escreveu:
| We're prematurely pampering the request queue before
| checking whether it was indeed allocated successfully.
|
| Against 2.6.6. Thanks.
|
|
| floppy.c | 2 +-
| 1 files changed, 1 insertion(+), 1 deletion(-)
|
| --- a/drivers/block/floppy.c 2004-05-20 23:48:04.000000000 +0200
| +++ b/drivers/block/floppy.c 2004-05-21 21:29:33.000000000 +0200
| @@ -4271,11 +4271,11 @@
| goto out;
|
| floppy_queue = blk_init_queue(do_fd_request, &floppy_lock);
| - blk_queue_max_sectors(floppy_queue, 64);
| if (!floppy_queue) {
| err = -ENOMEM;
| goto fail_queue;
| }
| + blk_queue_max_sectors(floppy_queue, 64);
|
| blk_register_region(MKDEV(FLOPPY_MAJOR, 0), 256, THIS_MODULE,
| floppy_find, NULL, NULL);
I and Randy did a (long) audit for floppy init sometime ago. It includes
your change. :-)
I think the patch will be in next -mm.
--
Luiz Fernando N. Capitulino
<http://www.telecentros.sp.gov.br>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()
2004-05-21 20:33 ` Luiz Fernando N. Capitulino
@ 2004-05-21 20:51 ` Arthur Othieno
0 siblings, 0 replies; 5+ messages in thread
From: Arthur Othieno @ 2004-05-21 20:51 UTC (permalink / raw)
To: lcapitulino; +Cc: akpm, linux-kernel
On Fri, May 21, 2004 at 05:33:20PM -0300, Luiz Fernando N. Capitulino wrote:
> Em Fri, May 21, 2004 at 09:59:34PM +0200, Arthur Othieno escreveu:
> | We're prematurely pampering the request queue before
> | checking whether it was indeed allocated successfully.
> |
> | Against 2.6.6. Thanks.
> |
> |
> | floppy.c | 2 +-
> | 1 files changed, 1 insertion(+), 1 deletion(-)
> |
snip
> I and Randy did a (long) audit for floppy init sometime ago. It includes
> your change. :-)
>
> I think the patch will be in next -mm.
Glad to hear that. It was beginning to look a little too scary ;)
Arthur
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-05-21 20:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-21 19:59 [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors() Arthur Othieno
2004-05-21 20:04 ` Jeff Garzik
2004-05-21 20:10 ` Zwane Mwaikambo
2004-05-21 20:33 ` Luiz Fernando N. Capitulino
2004-05-21 20:51 ` Arthur Othieno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).