LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andrew Morton <akpm@osdl.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PCMCIA] Check return status of register calls in i82365
Date: Sat, 22 May 2004 09:46:33 +1000	[thread overview]
Message-ID: <20040521234633.GA25889@gondor.apana.org.au> (raw)
In-Reply-To: <20040521164111.26e90aa6.akpm@osdl.org>

On Fri, May 21, 2004 at 04:41:11PM -0700, Andrew Morton wrote:
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > i82365 calls driver_register and platform_device_register without
> > checking their return values.  This patch fixes that.
> 
> It does more than that - you've also changed it to run platform_device_register()
> prior to isa_probe().  How come?

1. The platform device being registered is a place-holder that does not
   rely on the probing at all.
2. If it was done after the probe then should the registration fail, we'll
   have to roll back all the changes done by isa_probe().

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      reply	other threads:[~2004-05-22  0:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-21 11:55 Herbert Xu
2004-05-21 23:41 ` Andrew Morton
2004-05-21 23:46   ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040521234633.GA25889@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --subject='Re: [PCMCIA] Check return status of register calls in i82365' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).