LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Rik van Riel <riel@redhat.com>
Cc: John Cherry <cherry@osdl.org>, Andrew Morton <akpm@osdl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [patch] 2.6.7-rc1-mm1: fix set_8042_nomux warning
Date: Fri, 28 May 2004 14:32:59 +0200 [thread overview]
Message-ID: <20040528123259.GI16099@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0405272254590.30062-100000@chimarrao.boston.redhat.com>
On Thu, May 27, 2004 at 10:57:46PM -0400, Rik van Riel wrote:
> On Thu, 27 May 2004, John Cherry wrote:
>
> > CC arch/i386/kernel/dmi_scan.o
> > arch/i386/kernel/dmi_scan.c:410: warning: `set_8042_nomux' defined but
> > not used
>
> It's called from the dmi routines, with the function
> defined in the DMI table. No idea why this would
> give a warning while the other similar functions
> (eg broken_ps2_resume) don't ...
He's using a .config with CONFIG_ACPI_BOOT=n.
A fix is below.
cu
Adrian
--- linux-2.6.7-rc1-mm1-full/arch/i386/kernel/dmi_scan.c.old 2004-05-28 13:09:22.000000000 +0200
+++ linux-2.6.7-rc1-mm1-full/arch/i386/kernel/dmi_scan.c 2004-05-28 13:10:51.000000000 +0200
@@ -401,23 +401,6 @@
}
/*
- * HP Proliant 8500 systems can't use i8042 in mux mode,
- * or they instantly reboot.
- */
-#ifdef CONFIG_SERIO_I8042
-extern unsigned int i8042_nomux;
-static __init int set_8042_nomux(struct dmi_blacklist *d)
-{
- if (i8042_nomux == 0)
- {
- i8042_nomux = 1;
- printk(KERN_INFO "Disabling i8042 mux mode\n");
- }
- return 0;
-}
-#endif
-
-/*
* This bios swaps the APM minute reporting bytes over (Many sony laptops
* have this problem).
*/
@@ -516,6 +499,24 @@
#ifdef CONFIG_ACPI_BOOT
+
+/*
+ * HP Proliant 8500 systems can't use i8042 in mux mode,
+ * or they instantly reboot.
+ */
+#ifdef CONFIG_SERIO_I8042
+extern unsigned int i8042_nomux;
+static __init int set_8042_nomux(struct dmi_blacklist *d)
+{
+ if (i8042_nomux == 0)
+ {
+ i8042_nomux = 1;
+ printk(KERN_INFO "Disabling i8042 mux mode\n");
+ }
+ return 0;
+}
+#endif
+
extern int acpi_force;
static __init __attribute__((unused)) int dmi_disable_acpi(struct dmi_blacklist *d)
next prev parent reply other threads:[~2004-05-28 12:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-27 8:52 2.6.7-rc1-mm1 Andrew Morton
2004-05-27 11:53 ` 2.6.7-rc1-mm1 Andrey Panin
2004-05-27 18:20 ` 2.6.7-rc1-mm1 Andrew Morton
2004-05-28 5:46 ` 2.6.7-rc1-mm1 Andrey Panin
2004-05-28 5:52 ` 2.6.7-rc1-mm1 Andrew Morton
2004-05-28 6:05 ` 2.6.7-rc1-mm1 Andrey Panin
2004-05-28 10:37 ` 2.6.7-rc1-mm1 Dave Jones
2004-05-27 16:25 ` 2.6.7-rc1-mm1 (compile stats) John Cherry
2004-05-28 2:57 ` Rik van Riel
2004-05-28 12:32 ` Adrian Bunk [this message]
2004-05-28 19:25 ` 2.6.7-rc1-mm1 Rafał 'rmrmg' Roszak
2004-06-01 6:33 ` 2.6.7-rc1-mm1 Eric W. Biederman
2004-06-01 6:39 ` 2.6.7-rc1-mm1 Andrew Morton
2004-06-01 7:26 ` [Fastboot] 2.6.7-rc1-mm1 Eric W. Biederman
2004-06-01 6:38 ` 2.6.7-rc1-mm1 Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040528123259.GI16099@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=akpm@osdl.org \
--cc=cherry@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).