makefile fix

makefile fix

[carbonated beverage]

Every time I build on the Ultra, I get a file called "64" in the top-level
directory.  Here's a small patch to make it do the right thing(tm).

Note, I'm using ash as my /bin/sh.  Works for me, at least, with bash and
ash.

-- DN
Daniel

===== Makefile 1.487 vs edited =====
--- 1.487/Makefile	2004-05-19 09:02:53 -07:00
+++ edited/Makefile	2004-05-29 13:54:29 -07:00
@@ -680,7 +680,7 @@
 uts_len := 64
 
 define filechk_version.h
-	if ((`echo -n "$(KERNELRELEASE)" | wc -c ` > $(uts_len))); then \
+	if [ `echo -n "$(KERNELRELEASE)" | wc -c ` -gt $(uts_len) ]; then \
 	  echo '"$(KERNELRELEASE)" exceeds $(uts_len) characters' >&2; \
 	  exit 1; \
 	fi; \

Re: makefile fix

[Paul Jackson]

The (( x > y )) syntax looks like ksh stuff,
equivalent to the more widely supported [ x -gt y ].

Your patch looks reasonable to me.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

Re: makefile fix

[Sam Ravnborg]

On Sat, May 29, 2004 at 01:51:09PM -0700, carbonated beverage wrote:
> Every time I build on the Ultra, I get a file called "64" in the top-level
> directory.  Here's a small patch to make it do the right thing(tm).
> 
> Note, I'm using ash as my /bin/sh.  Works for me, at least, with bash and
> ash.

Patch is already in Linus' tree. Christoph digged it out of Debian.

	Sam

RE: makefile fix

[Piszcz, Justin Michael]

Quick FYI:

Bash supports C-style if() statements using double parenthesis.

$ if (( 5 > 3 )); then
> echo hi
> fi
Hi


-----Original Message-----
From: linux-kernel-owner@vger.kernel.org
[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Paul Jackson
Sent: Sunday, May 30, 2004 7:39 PM
To: carbonated beverage
Cc: linux-kernel@vger.kernel.org
Subject: Re: makefile fix

The (( x > y )) syntax looks like ksh stuff,
equivalent to the more widely supported [ x -gt y ].

Your patch looks reasonable to me.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/