LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Sean Neakums <sneakums@zork.net>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: Scroll wheel on PS/2 Logitech MouseMan Wheel no longer works (was Re: 2.6.6-mm3)
Date: Sun, 6 Jun 2004 19:49:42 +0200	[thread overview]
Message-ID: <20040606174942.GC6561@ucw.cz> (raw)
In-Reply-To: <200405252240.29353.dtor_core@ameritech.net>

On Tue, May 25, 2004 at 10:40:25PM -0500, Dmitry Torokhov wrote:
> On Thursday 20 May 2004 02:49 am, Sean Neakums wrote:
> > Dmitry Torokhov <dtor_core@ameritech.net> writes:
> > > >
> > > Hmm... it indeed reports REL_X and REL_Y events instead of REL_WHEEL... So
> > > its definitely not a mousedev problem. Could you also try booting with
> > > psmouse.proto=exps and see if it still behaves sanely?
> > 
> > The scrolls wheel appears to do nothing when I boot with psmouse.proto=exps.
> > Here's what the mouse is shown as in /proc/bus/input/devices:
> > 
> 
> Hi,
> 
> Sorry for delay with my answer. I got a hold of a mouse that supports
> Explorer PS/2 protocol and it works fine here. Still could you try
> reverting the patch below and see if it restores the correct behavior.

I think I have a similar fix in the tree already.

> 
> Thanks!
> 
> -- 
> Dmitry
> 
> 
> ===================================================================
> 
> 
> ChangeSet@1.1612.1.17, 2004-05-14 11:18:46+02:00, vojtech@suse.cz
>   input: Check for IM Explorer mice even if IMPS check failed.
> 
> 
>  psmouse-base.c |   21 +++++++++++----------
>  1 files changed, 11 insertions(+), 10 deletions(-)
> 
> 
> ===================================================================
> 
> 
> 
> diff -Nru a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
> --- a/drivers/input/mouse/psmouse-base.c	2004-05-25 22:38:24 -05:00
> +++ b/drivers/input/mouse/psmouse-base.c	2004-05-25 22:38:24 -05:00
> @@ -461,24 +461,25 @@
>  			return type;
>  	}
>  
> -	if (max_proto >= PSMOUSE_IMPS && intellimouse_detect(psmouse)) {
> +	if (max_proto >= PSMOUSE_IMEX && im_explorer_detect(psmouse)) {
>  
>  		if (set_properties) {
>  			set_bit(REL_WHEEL, psmouse->dev.relbit);
> +			set_bit(BTN_SIDE, psmouse->dev.keybit);
> +			set_bit(BTN_EXTRA, psmouse->dev.keybit);
>  			if (!psmouse->name)
> -				psmouse->name = "Wheel Mouse";
> +				psmouse->name = "Explorer Mouse";
>  		}
>  
> -		if (max_proto >= PSMOUSE_IMEX && im_explorer_detect(psmouse)) {
> +		return PSMOUSE_IMEX;
> +	}
>  
> -			if (!set_properties) {
> -				set_bit(BTN_SIDE, psmouse->dev.keybit);
> -				set_bit(BTN_EXTRA, psmouse->dev.keybit);
> -				if (!psmouse->name)
> -					psmouse->name = "Explorer Mouse";
> -			}
> +	if (max_proto >= PSMOUSE_IMPS && intellimouse_detect(psmouse)) {
>  
> -			return PSMOUSE_IMEX;
> +		if (set_properties) {
> +			set_bit(REL_WHEEL, psmouse->dev.relbit);
> +			if (!psmouse->name)
> +				psmouse->name = "Wheel Mouse";
>  		}
>  
>  		return PSMOUSE_IMPS;
> 

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

  reply	other threads:[~2004-06-06 17:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-16  9:55 2.6.6-mm3 Andrew Morton
2004-05-16 10:35 ` 2.6.6-mm3 Prakash K. Cheemplavam
2004-05-16 11:00   ` 2.6.6-mm3 Gene Heskett
2004-05-16 16:29   ` 2.6.6-mm3 Andrew Morton
2004-05-16 18:38 ` 2.6.6-mm3: USB console.c doesn't compile Adrian Bunk
2004-05-17 16:32   ` Greg KH
2004-05-16 20:15 ` [patch] 2.6.6-mm3: more PC9800 removal Adrian Bunk
2004-05-16 20:35 ` [patch] 2.6.6-mm3: remove PC9800 from should-fix Adrian Bunk
2004-05-17 11:52 ` 2.6.6-mm3 Eric W. Biederman
2004-05-17 12:57 ` 2.6.6-mm3 Aristeu Sergio Rozanski Filho
2004-05-17 15:06   ` 2.6.6-mm3 Robert Picco
2004-05-17 15:51     ` 2.6.6-mm3 Aristeu Sergio Rozanski Filho
2004-05-17 13:09 ` Scroll wheel on PS/2 Logitech MouseMan Wheel no longer works (was Re: 2.6.6-mm3) Sean Neakums
2004-05-17 18:10   ` Dmitry Torokhov
     [not found]     ` <6u4qqejiny.fsf@zork.zork.net>
     [not found]       ` <200405191256.32335.dtor_core@ameritech.net>
2004-05-20  7:49         ` Sean Neakums
2004-05-26  3:40           ` Dmitry Torokhov
2004-06-06 17:49             ` Vojtech Pavlik [this message]
2004-05-17 16:14 ` 2.6.6-mm3 Tom Rini
2004-05-17 16:30   ` 2.6.6-mm3 Robert Picco
2004-05-17 16:38     ` 2.6.6-mm3 Tom Rini
2004-05-17 17:56       ` 2.6.6-mm3 Tom Rini
2004-05-18 13:45         ` [Kgdb-bugreport] 2.6.6-mm3 Amit S. Kale
2004-05-17 17:20 ` 2.6.6-mm3 Chris Wright
2004-05-17 17:42 ` [PATCH][PPC32] Update Motorola LoPEC and Sandpoint defconfigs Tom Rini
2004-05-17 17:54   ` [PATCH][PPC32] Remove 'mem_pieces_append' Tom Rini
2004-05-17 18:06     ` [PATCH][PPC32] Some fixes for 'make O=...' Tom Rini
2004-05-18  2:08 ` 2.6.6-mm3: i810 agpgart module can't be initialized Clemens Schwaighofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040606174942.GC6561@ucw.cz \
    --to=vojtech@suse.cz \
    --cc=akpm@osdl.org \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sneakums@zork.net \
    --subject='Re: Scroll wheel on PS/2 Logitech MouseMan Wheel no longer works (was Re: 2.6.6-mm3)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).