LKML Archive on
help / color / mirror / Atom feed
From: Sam Ravnborg <>
To: Jeff Garzik <>
Cc: Grzegorz Kulewski <>,,,
Subject: Re: [PATCH] linux/magic.h for magic numbers
Date: Sat, 9 Sep 2006 15:33:34 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, Sep 09, 2006 at 09:24:22AM -0400, Jeff Garzik wrote:
> Grzegorz Kulewski wrote:
> >On Sat, 9 Sep 2006, Jeff Garzik wrote:
> >>An IRC discussion sparked a memory:  most filesystems really don't
> >>need to put anything at all in include/linux.  Excluding API-ish
> >>filesystems like procfs, just about the only filesystem symbols that
> >>get exported outside of __KERNEL__ are the *_SUPER_MAGIC symbols,
> >>and similar symbols.
> >>
> >>After seeing the useful attributes of linux/poison.h, I propose a
> >>similar linux/magic.h.
> >
> >But... if some patch changes this file (like adding new magic symbol) it 
> >will cause large part of the kernel to rebuild without any good reason. No?
> No :)
> * The days when linux/fs.h included individual filesystem headers is 
> long gone.  Only the filesystems themselves typically include the 
> linux/foo_fs*.h files these days.

But do we want one common set of magic numbers or do we try to divide it
up per subssystem. The lattter approach are used for many other purposes
so why not for magics too?
Or in other word magic.h => fs_magic.h


  reply	other threads:[~2006-09-09 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-09 11:02 Jeff Garzik
2006-09-09 12:58 ` Grzegorz Kulewski
2006-09-09 13:24   ` Jeff Garzik
2006-09-09 13:33     ` Sam Ravnborg [this message]
2006-09-09 13:44       ` Jeff Garzik
2006-09-12  8:22 ` Ian Kent
2006-09-12  9:33   ` Jan Engelhardt
2006-09-12 12:30   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] linux/magic.h for magic numbers' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).