Re: [PATCH] linux/magic.h for magic numbers

[Sam Ravnborg <sam@ravnborg.org>]

On Sat, Sep 09, 2006 at 09:24:22AM -0400, Jeff Garzik wrote:
> Grzegorz Kulewski wrote:
> >On Sat, 9 Sep 2006, Jeff Garzik wrote:
> >>An IRC discussion sparked a memory:  most filesystems really don't
> >>need to put anything at all in include/linux.  Excluding API-ish
> >>filesystems like procfs, just about the only filesystem symbols that
> >>get exported outside of __KERNEL__ are the *_SUPER_MAGIC symbols,
> >>and similar symbols.
> >>
> >>After seeing the useful attributes of linux/poison.h, I propose a
> >>similar linux/magic.h.
> >
> >But... if some patch changes this file (like adding new magic symbol) it 
> >will cause large part of the kernel to rebuild without any good reason. No?
> 
> No :)
> 
> * The days when linux/fs.h included individual filesystem headers is 
> long gone.  Only the filesystems themselves typically include the 
> linux/foo_fs*.h files these days.

But do we want one common set of magic numbers or do we try to divide it
up per subssystem. The lattter approach are used for many other purposes
so why not for magics too?
Or in other word magic.h => fs_magic.h

	Sam