LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: "Michael Matz" <matz@suse.de>,
	"Richard Guenther" <rguenther@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [development-gcc] Re: do_exit stuck
Date: Mon, 11 Sep 2006 22:17:16 +0200	[thread overview]
Message-ID: <200609112217.16811.ak@suse.de> (raw)
In-Reply-To: <45059EEB.76E4.0078.0@novell.com>

On Monday 11 September 2006 17:37, Jan Beulich wrote:
> >>> Andi Kleen <ak@suse.de> 30.08.06 17:40 >>>
> >
> >On Wednesday 30 August 2006 17:28, Jan Beulich wrote:
> >> >Hmm, yes.  Sigh, so it's either gcc changes or binutils changes, and
> >> > none of that can be relied upon, except someone has a better idea to
> >> > identify signal frames with high enough assurance to be sensible for
> >> > debugging.
> >>
> >> The only alternative idea I have is to take into consideration the
> >> location of the return address: if it's at the default location (top of
> >> call frame), then assume this is a normal frame, in all other cases
> >> assume it's an interrupt/exception one. This will probably get a few
> >> cases wrong (where the return address is being played with), but it
> >> might be better than the current situation. Andi?
> >
> >Fine by me.
> >
> >At least it will likely be less controversal than changing all the
> > noreturns :)
>
> Here's a patch, including all that I think is necessary once we selectively
> enable (auto-detect) CONFIG_AS_CFI_SIGNAL_FRAME for newer binutils.
> It doesn't include adjustment of the printed address (i.e. for the original
> example, it'd still be kernel_math_error+0 that gets displayed, but the
> unwinder wouldn't get confused anymore.

Thanks.

Isn't a Kconfig patch missing? I don't see any place that defines 
CONFIG_AS_CFI_SIGNAL_FRAME. Actually Kconfig wouldn't 
be very good for this, so auto testing would be preferable
(like the cfi test is doing) 

BTW the tree you generated it against doesn't seem to match the latest
tree. I had to fix some rejects.

Also it would be nice if you could give a full description that could
be used as a commit message.

Other than that it looks good.

Ok maybe a one liner comment on why UNW_DEFAULT_RA does this magic.

-Andi

  reply	other threads:[~2006-09-11 21:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200608291332.18499.ak@suse.de>
     [not found] ` <Pine.LNX.4.64.0608301626150.6582@wotan.suse.de>
     [not found]   ` <44F5CAD0.76E4.0078.0@novell.com>
     [not found]     ` <200608301740.41729.ak@suse.de>
2006-09-11 15:37       ` Jan Beulich
2006-09-11 20:17         ` Andi Kleen [this message]
2006-09-12  6:57           ` Jan Beulich
2006-09-12  6:32             ` Andi Kleen
2006-09-12  8:35               ` Jakub Jelinek
2006-09-12  8:45               ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200609112217.16811.ak@suse.de \
    --to=ak@suse.de \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matz@suse.de \
    --cc=rguenther@suse.de \
    --subject='Re: [development-gcc] Re: do_exit stuck' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).