LKML Archive on
help / color / mirror / Atom feed
From: "Serge E. Hallyn" <>
To: "Eric W. Biederman" <>
Cc: Andrew Morton <>,
	Linux Containers <>,
Subject: Re: [PATCH 3/4] sysctl: Simplify ipc ns specific sysctls
Date: Tue, 28 Nov 2006 22:56:19 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Quoting Eric W. Biederman (
> This patch refactors the ipc sysctl support so that it is
> simpler, more readable, and prepares for fixing the bug
> with the wrong values being returned in the sys_sysctl interface.
> The function proc_do_ipc_string was misnamed as it never handled
> strings.  It's magic of when to work with strings and when to work
> with longs belonged in the sysctl table.  I couldn't tell if the
> code would work if you disabled the ipc namespace but it certainly
> looked like it would have problems.
> Signed-off-by: Eric W. Biederman <>


A little belated (sorry), but the only comment I have right now on the
patchset is that the get_ipc() seems like it shouldn't take the write
arg.  Perhaps if consistency is the concern, get_uts() should simply
be called get_uts_locked(table, need_write) ?  This also avoids the
mysterious '1' argument in the next patch at get_ipc(table, 1);

Oh, I lied, one more comment.  It seems worth a comment at the top of
get_uts() and get_ipc() explaining that table->data points to
init_uts->data and that's why the 'which = which - init_uts + uts'


  reply	other threads:[~2006-11-29  4:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-27  4:59 [PATCH 0/4] Fix the binary ipc and uts namespace sysctls Eric W. Biederman
2006-11-27  5:05 ` [PATCH 1/4] sysctl: Simplify sysctl_uts_string Eric W. Biederman
2006-11-27  5:05 ` [PATCH 2/4] sysctl: Implement sysctl_uts_string Eric W. Biederman
2006-11-27  5:05 ` [PATCH 3/4] sysctl: Simplify ipc ns specific sysctls Eric W. Biederman
2006-11-29  4:56   ` Serge E. Hallyn [this message]
2006-11-27  5:05 ` [PATCH 4/4] sysctl: Fix sys_sysctl interface of ipc sysctls Eric W. Biederman
2006-11-27 20:22 ` [PATCH 0/4] Fix the binary ipc and uts namespace sysctls Herbert Poetzl
2006-11-27 22:40   ` Eric W. Biederman
2006-11-28 14:32     ` Herbert Poetzl
2006-11-28 15:38       ` Eric W. Biederman
2006-11-28 16:21         ` Herbert Poetzl
2006-12-04 22:32         ` [PATCH] Fix linux banner utsname information Herbert Poetzl
2006-12-05 17:24           ` Herbert Poetzl
2006-12-06 18:32             ` Herbert Poetzl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH 3/4] sysctl: Simplify ipc ns specific sysctls' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).