[PATCH] VIA and SiS AGP chipsets are x86-only

[PATCH] VIA and SiS AGP chipsets are x86-only

[Matthew Wilcox]

There's no point in troubling the Alpha, IA-64, PowerPC and PARISC
people with SiS and VIA options.  Andrew thinks it helps find bugs,
but there's no evidence of that.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>

diff --git a/drivers/char/agp/Kconfig b/drivers/char/agp/Kconfig
index c603bf2..a9f9c48 100644
--- a/drivers/char/agp/Kconfig
+++ b/drivers/char/agp/Kconfig
@@ -86,7 +86,7 @@ config AGP_NVIDIA
 
 config AGP_SIS
 	tristate "SiS chipset support"
-	depends on AGP
+	depends on AGP && X86
 	help
 	  This option gives you AGP support for the GLX component of
 	  X on Silicon Integrated Systems [SiS] chipsets.
@@ -103,7 +103,7 @@ config AGP_SWORKS
 
 config AGP_VIA
 	tristate "VIA chipset support"
-	depends on AGP
+	depends on AGP && X86
 	help
 	  This option gives you AGP support for the GLX component of
 	  X on VIA MVP3/Apollo Pro chipsets.

Re: [PATCH] VIA and SiS AGP chipsets are x86-only

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew Wilcox wrote:
> There's no point in troubling the Alpha, IA-64, PowerPC and PARISC
> people with SiS and VIA options.  Andrew thinks it helps find bugs,
> but there's no evidence of that.
> 
> Signed-off-by: Matthew Wilcox <matthew@wil.cx>
> 
> diff --git a/drivers/char/agp/Kconfig b/drivers/char/agp/Kconfig
> index c603bf2..a9f9c48 100644
> --- a/drivers/char/agp/Kconfig
> +++ b/drivers/char/agp/Kconfig
> @@ -86,7 +86,7 @@ config AGP_NVIDIA
> 
>  config AGP_SIS
>  	tristate "SiS chipset support"
> -	depends on AGP
> +	depends on AGP && X86
>  	help
>  	  This option gives you AGP support for the GLX component of
>  	  X on Silicon Integrated Systems [SiS] chipsets.
> @@ -103,7 +103,7 @@ config AGP_SWORKS
> 
>  config AGP_VIA
>  	tristate "VIA chipset support"
> -	depends on AGP
> +	depends on AGP && X86
>  	help
>  	  This option gives you AGP support for the GLX component of
>  	  X on VIA MVP3/Apollo Pro chipsets.

I don't know about SiS, but this is certainly *not* true for Via.  There
are some PowerPC and, IIRC, Alpha motherboards that have Via chipsets.
My config-fu isn't quite what it should be, so this may be a dumb
question.  Does the "& X86" requirement exclude x86-64?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFdfkpX1gOwKyEAw8RAmh9AJ42g79Q9isQ0mzy87ILFn8pyW9AjACfWFdu
DvPS3GGDJyFfYfaf/8b5H4Y=
=NlmP
-----END PGP SIGNATURE-----

Re: [PATCH] VIA and SiS AGP chipsets are x86-only

[Randy Dunlap]

On Tue, 05 Dec 2006 14:56:41 -0800 Ian Romanick wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Matthew Wilcox wrote:
> > There's no point in troubling the Alpha, IA-64, PowerPC and PARISC
> > people with SiS and VIA options.  Andrew thinks it helps find bugs,
> > but there's no evidence of that.
> > 
> > Signed-off-by: Matthew Wilcox <matthew@wil.cx>
> > 
> > diff --git a/drivers/char/agp/Kconfig b/drivers/char/agp/Kconfig
> > index c603bf2..a9f9c48 100644
> > --- a/drivers/char/agp/Kconfig
> > +++ b/drivers/char/agp/Kconfig
> > @@ -86,7 +86,7 @@ config AGP_NVIDIA
> > 
> >  config AGP_SIS
> >  	tristate "SiS chipset support"
> > -	depends on AGP
> > +	depends on AGP && X86
> >  	help
> >  	  This option gives you AGP support for the GLX component of
> >  	  X on Silicon Integrated Systems [SiS] chipsets.
> > @@ -103,7 +103,7 @@ config AGP_SWORKS
> > 
> >  config AGP_VIA
> >  	tristate "VIA chipset support"
> > -	depends on AGP
> > +	depends on AGP && X86
> >  	help
> >  	  This option gives you AGP support for the GLX component of
> >  	  X on VIA MVP3/Apollo Pro chipsets.
> 
> I don't know about SiS, but this is certainly *not* true for Via.  There
> are some PowerPC and, IIRC, Alpha motherboards that have Via chipsets.
> My config-fu isn't quite what it should be, so this may be a dumb
> question.  Does the "& X86" requirement exclude x86-64?

No, X86 includes both X86_32 and X86_64.

---
~Randy

Re: [PATCH] VIA and SiS AGP chipsets are x86-only

[Matthew Wilcox]

On Tue, Dec 05, 2006 at 02:56:41PM -0800, Ian Romanick wrote:
> I don't know about SiS, but this is certainly *not* true for Via.  There
> are some PowerPC and, IIRC, Alpha motherboards that have Via chipsets.

Yes, but they don't have VIA *AGP*.  At least, that's what I've been
told by people who know those architectures.

Re: [PATCH] VIA and SiS AGP chipsets are x86-only

[Benjamin Herrenschmidt]

On Tue, 2006-12-05 at 20:40 -0700, Matthew Wilcox wrote:
> On Tue, Dec 05, 2006 at 02:56:41PM -0800, Ian Romanick wrote:
> > I don't know about SiS, but this is certainly *not* true for Via.  There
> > are some PowerPC and, IIRC, Alpha motherboards that have Via chipsets.
> 
> Yes, but they don't have VIA *AGP*.  At least, that's what I've been
> told by people who know those architectures.

Yeah, I don't know of any VIA AGP chipset used on ppc... 

Pegasos has a VIA southbridge but no AGP.

Ben.

Re: [PATCH] VIA and SiS AGP chipsets are x86-only

[Alan]

On Tue, 5 Dec 2006 20:40:45 -0700
Matthew Wilcox <matthew@wil.cx> wrote:

> On Tue, Dec 05, 2006 at 02:56:41PM -0800, Ian Romanick wrote:
> > I don't know about SiS, but this is certainly *not* true for Via.  There
> > are some PowerPC and, IIRC, Alpha motherboards that have Via chipsets.
> 
> Yes, but they don't have VIA *AGP*.  At least, that's what I've been
> told by people who know those architectures.

VIA south gets used by a lot of the systems but the VIA North bridges
I've got docs for cover only x86 variants, although one of the older ones
implies it has both K7 and Alpha support (just as the AMD chipset does)

Personally I'd rather know when I broke stuff by getting everything
to compile that sanely compiles. Operating the ".config" file is not
complex after all.

Alan

Re: [PATCH] VIA and SiS AGP chipsets are x86-only

[Ivan Kokshaysky]

On Wed, Dec 06, 2006 at 10:38:48AM +0000, Alan wrote:
> VIA south gets used by a lot of the systems but the VIA North bridges
> I've got docs for cover only x86 variants, although one of the older ones
> implies it has both K7 and Alpha support (just as the AMD chipset does)

VIA chips (even southbridges) have never been used on Alpha.

Ivan.

Re: [PATCH] VIA and SiS AGP chipsets are x86-only

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Benjamin Herrenschmidt wrote:
> On Tue, 2006-12-05 at 20:40 -0700, Matthew Wilcox wrote:
>> On Tue, Dec 05, 2006 at 02:56:41PM -0800, Ian Romanick wrote:
>>> I don't know about SiS, but this is certainly *not* true for Via.  There
>>> are some PowerPC and, IIRC, Alpha motherboards that have Via chipsets.
>> Yes, but they don't have VIA *AGP*.  At least, that's what I've been
>> told by people who know those architectures.
> 
> Yeah, I don't know of any VIA AGP chipset used on ppc...
> 
> Pegasos has a VIA southbridge but no AGP.

I double checked, and you're right.  Please ignore my noise.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFdvr3X1gOwKyEAw8RAocaAJ4whaDqaAmCFzAgrnzyD+1bD/SRXACfb5eM
TcFVnRBmMQUyU8wyOxLISHE=
=ST0m
-----END PGP SIGNATURE-----