LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk> To: Linus Torvalds <torvalds@osdl.org> Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org Subject: more work_struct-induced breakage Date: Wed, 6 Dec 2006 18:51:40 +0000 [thread overview] Message-ID: <20061206185140.GD4587@ftp.linux.org.uk> (raw) In-Reply-To: <20061206184145.GC4587@ftp.linux.org.uk> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/drivers/net/hamradio/dmascc.c b/drivers/net/hamradio/dmascc.c index 0f8b9af..e6e721a 100644 --- a/drivers/net/hamradio/dmascc.c +++ b/drivers/net/hamradio/dmascc.c @@ -252,7 +252,7 @@ static inline void z8530_isr(struct scc_ static irqreturn_t scc_isr(int irq, void *dev_id); static void rx_isr(struct scc_priv *priv); static void special_condition(struct scc_priv *priv, int rc); -static void rx_bh(void *arg); +static void rx_bh(struct work_struct *); static void tx_isr(struct scc_priv *priv); static void es_isr(struct scc_priv *priv); static void tm_isr(struct scc_priv *priv); @@ -579,7 +579,7 @@ static int __init setup_adapter(int card priv->param.clocks = TCTRxCP | RCRTxCP; priv->param.persist = 256; priv->param.dma = -1; - INIT_WORK(&priv->rx_work, rx_bh, priv); + INIT_WORK(&priv->rx_work, rx_bh); dev->priv = priv; sprintf(dev->name, "dmascc%i", 2 * n + i); dev->base_addr = card_base; @@ -1272,9 +1272,9 @@ static void special_condition(struct scc } -static void rx_bh(void *arg) +static void rx_bh(struct work_struct *ugli_api) { - struct scc_priv *priv = arg; + struct scc_priv *priv = container_of(ugli_api, struct scc_priv, rx_work); int i = priv->rx_tail; int cb; unsigned long flags;
next prev parent reply other threads:[~2006-12-06 18:51 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2006-12-06 18:41 work_struct-induced breakage, part 1 of fsck-knows-how-many Al Viro 2006-12-06 18:51 ` Al Viro [this message] 2006-12-06 19:18 ` and more of the same Al Viro 2006-12-06 19:46 ` ... and more Al Viro 2006-12-06 19:50 ` Al Viro 2006-12-06 21:15 ` ... and then some Al Viro 2006-12-07 13:08 ` ... and more David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20061206185140.GD4587@ftp.linux.org.uk \ --to=viro@ftp.linux.org.uk \ --cc=dhowells@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=torvalds@osdl.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).