LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: cmpxchg() in kernel/workqueue.c breaks things
Date: Thu, 07 Dec 2006 00:09:50 -0800 (PST)	[thread overview]
Message-ID: <20061207.000950.28414823.davem@davemloft.net> (raw)


David, you have to fix the locking scheme used in kernel/workqueue.c,
you absolutely cannot assume that cmpxchg() is available on all
platforms.  This breaks the build on the platforms that don't
have such an instruction, and no it cannot emulated.

Also, because Alan Cox's machine (zeniv) went down, a few folks such
as Al Viro (CC:'d) had no opportunity to comment on your changes
before they went in.  This mess would have been avoided if Al had a
chance to read over this, in particular since he does cross sparc32
builds he knows that cmpxchg is not available there.

             reply	other threads:[~2006-12-07  8:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07  8:09 David Miller [this message]
2006-12-07  8:23 ` Al Viro
2006-12-07 11:03 ` David Howells
2006-12-07 11:28   ` Andrew Morton
2006-12-07 11:46   ` David Howells
2006-12-07 16:35     ` Andrew Morton
2006-12-07 13:24 ` David Howells
2006-12-07 14:53 ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061207.000950.28414823.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@osdl.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: cmpxchg() in kernel/workqueue.c breaks things' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).