LKML Archive on
help / color / mirror / Atom feed
From: Al Viro <>
To: David Miller <>
Subject: Re: cmpxchg() in kernel/workqueue.c breaks things
Date: Thu, 7 Dec 2006 08:23:32 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Dec 07, 2006 at 12:09:50AM -0800, David Miller wrote:
> David, you have to fix the locking scheme used in kernel/workqueue.c,
> you absolutely cannot assume that cmpxchg() is available on all
> platforms.  This breaks the build on the platforms that don't
> have such an instruction, and no it cannot emulated.
> Also, because Alan Cox's machine (zeniv) went down, a few folks such
> as Al Viro (CC:'d) had no opportunity to comment on your changes
> before they went in.  This mess would have been avoided if Al had a
> chance to read over this, in particular since he does cross sparc32
> builds he knows that cmpxchg is not available there.

FWIW, the *real* problem with that (and several other recent breakage
incidents) would be avoided if massive cross-arch patchsets would be
posted to linux-arch first.

It wouldn't catch all crap, but at least it would get folks to check
if the damn thing builds.

  reply	other threads:[~2006-12-07  8:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07  8:09 David Miller
2006-12-07  8:23 ` Al Viro [this message]
2006-12-07 11:03 ` David Howells
2006-12-07 11:28   ` Andrew Morton
2006-12-07 11:46   ` David Howells
2006-12-07 16:35     ` Andrew Morton
2006-12-07 13:24 ` David Howells
2006-12-07 14:53 ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: cmpxchg() in kernel/workqueue.c breaks things' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).