LKML Archive on
help / color / mirror / Atom feed
* cmpxchg() in kernel/workqueue.c breaks things
@ 2006-12-07  8:09 David Miller
  2006-12-07  8:23 ` Al Viro
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: David Miller @ 2006-12-07  8:09 UTC (permalink / raw)
  To: dhowells; +Cc: viro, linux-kernel, akpm

David, you have to fix the locking scheme used in kernel/workqueue.c,
you absolutely cannot assume that cmpxchg() is available on all
platforms.  This breaks the build on the platforms that don't
have such an instruction, and no it cannot emulated.

Also, because Alan Cox's machine (zeniv) went down, a few folks such
as Al Viro (CC:'d) had no opportunity to comment on your changes
before they went in.  This mess would have been avoided if Al had a
chance to read over this, in particular since he does cross sparc32
builds he knows that cmpxchg is not available there.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2006-12-07 16:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-07  8:09 cmpxchg() in kernel/workqueue.c breaks things David Miller
2006-12-07  8:23 ` Al Viro
2006-12-07 11:03 ` David Howells
2006-12-07 11:28   ` Andrew Morton
2006-12-07 11:46   ` David Howells
2006-12-07 16:35     ` Andrew Morton
2006-12-07 13:24 ` David Howells
2006-12-07 14:53 ` Russell King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).