Re: [PATCH] input/spi: add ads7843 support to ads7846 touchscreen driver

[David Brownell <david-b@pacbell.net>]

On Friday 15 December 2006 7:20 am, Nicolas FERRE wrote:
> Add support for the ads7843 touchscreen controller to the ads7846 driver code.

Glad to see this!  Is this for AT91sam9261-EK board support, maybe?


> The "pen down" information is managed quite differently as we do not have a
> touch-presure mesurement on the ads7843.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
> ---
> 
> I add a ads7843_rx function to manage the end of a measurement cycle. As for
> ads7846_rx, it does the real work and comnunicates with the input subsystem.
> The timer function is responsible of taking the pen up/pen down state through
> the board specific get_pendown_state() callback.

Hmm, unfortunately there are a lot of updates to this driver sitting in
the linux-omap tree ... the N770 guys really put a lot of solid work into
it (ISTR seeing a statistical plot showing how touchscreen debounce helps
get stable readings!), but those patches didn't get upstream yet.

One of the more critical of those patches addressed much the same pendown
state issue; it turns out that measuring pressure (after the pendown irq)
isn't the best way to notice when pen status becomes "up".

Let me try to sort out the mess with those updates, and ask you to refresh
this ads7843 support against that more-current ads7846 code.  (Or if you
want a preview, have a look at the linux-omap tree.  There's a clone of
that in the GIT area on kernel.org if you want.)


> As the SPI underlying code behaves quite differently from a controller driver
> to another whan not having a tx_buf filled, I have add a zerroed buffer to give
> to the spi layer while receiving data.

You must be working with a buggy controller driver then.  That part of
this patch should never be needed.  It's expected that rx-only transfers
will omit a tx buf; all controller drivers must handle that case.

- Dave


> Already posted to lkml :
> http://lkml.org/lkml/2006/12/15/71
>