LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Stephane Eranian <eranian@hpl.hp.com>
Cc: linux-kernel@vger.kernel.org, venkatesh.pallipadi@intel.com,
suresh.b.siddha@intel.com, kenneth.w.chen@intel.com,
tony.luck@intel.com, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] sched: improve sched_clock() on i686
Date: Sat, 23 Dec 2006 11:27:07 +0100 [thread overview]
Message-ID: <20061223102707.GA20251@elte.hu> (raw)
In-Reply-To: <20061222121920.GA3809@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> it's purely historic - the i686 sched_clock() implementation predates
> the scheduler's ability to deal with non-synchronous per-CPU clocks. I
> tried to fix that (a year ago) and it didnt work out - but i've
> reviewed my old patch and now realize what the mistake was - the patch
> below should work better.
that patch needs the small fix below as well.
Ingo
Index: linux/include/asm-i386/bugs.h
===================================================================
--- linux.orig/include/asm-i386/bugs.h
+++ linux/include/asm-i386/bugs.h
@@ -160,7 +160,7 @@ static void __init check_config(void)
* If we configured ourselves for a TSC, we'd better have one!
*/
#ifdef CONFIG_X86_TSC
- if (!cpu_has_tsc)
+ if (!cpu_has_tsc && !tsc_disable)
panic("Kernel compiled for Pentium+, requires TSC feature!");
#endif
next prev parent reply other threads:[~2006-12-23 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 10:43 sched_clock() on i386 Stephane Eranian
2006-12-22 12:19 ` [patch] sched: improve sched_clock() on i686 Ingo Molnar
2006-12-23 10:27 ` Ingo Molnar [this message]
2007-01-17 11:05 ` Stephane Eranian
2006-12-23 15:53 ` sched_clock() on i386 Daniel Walker
2007-01-03 14:36 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061223102707.GA20251@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=eranian@hpl.hp.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tony.luck@intel.com \
--cc=venkatesh.pallipadi@intel.com \
--subject='Re: [patch] sched: improve sched_clock() on i686' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).