LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc3] DAC960: kmalloc->kzalloc/Casting cleanups
Date: Sat, 6 Jan 2007 09:46:30 -0800
Message-ID: <20070106094630.51aa62e8.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20070106131725.GB19020@Ahmed>

On Sat, 6 Jan 2007 15:17:25 +0200 Ahmed S. Darwish wrote:

> Hi all,
> I'm not able to find the DAC960 block driver maintainer. If someones knows
> please reply :).

It's orphaned.  Andrew can decide to merge this, or one of the
storage or block maintainers could possibly do that.
or it could go thru KJ, but then Andrew may still end up
merging it.


> A patch to switch kmalloc->kzalloc and to clean unneeded kammloc,
> pci_alloc_consistent casts
> 
> Signed-off-by: Ahmed Darwish <darwish.07@gmail.com>
> 
> diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
> index 8d81a3a..4febe7f 100644
> --- a/drivers/block/DAC960.c
> +++ b/drivers/block/DAC960.c
> @@ -1373,8 +1373,7 @@ static boolean DAC960_V2_EnableMemoryMailboxInterface(DAC960_Controller_T
>    Controller->BounceBufferLimit = DAC690_V2_PciDmaMask;
>  
>    /* This is a temporary dma mapping, used only in the scope of this function */
> -  CommandMailbox =
> -	  (DAC960_V2_CommandMailbox_T *)pci_alloc_consistent( PCI_Device,
> +  CommandMailbox = pci_alloc_consistent(PCI_Device,
>  		sizeof(DAC960_V2_CommandMailbox_T), &CommandMailboxDMA);
>    if (CommandMailbox == NULL)
>  	  return false;
> @@ -1879,8 +1878,8 @@ static boolean DAC960_V2_ReadControllerConfiguration(DAC960_Controller_T
>        if (NewLogicalDeviceInfo->LogicalDeviceState !=
>  	  DAC960_V2_LogicalDevice_Offline)
>  	Controller->LogicalDriveInitiallyAccessible[LogicalDeviceNumber] = true;
> -      LogicalDeviceInfo = (DAC960_V2_LogicalDeviceInfo_T *)
> -	kmalloc(sizeof(DAC960_V2_LogicalDeviceInfo_T), GFP_ATOMIC);
> +      LogicalDeviceInfo = kmalloc(sizeof(DAC960_V2_LogicalDeviceInfo_T),
> +				   GFP_ATOMIC);
>        if (LogicalDeviceInfo == NULL)
>  	return DAC960_Failure(Controller, "LOGICAL DEVICE ALLOCATION");
>        Controller->V2.LogicalDeviceInformation[LogicalDeviceNumber] =
> @@ -2113,8 +2112,8 @@ static boolean DAC960_V2_ReadDeviceConfiguration(DAC960_Controller_T
>        if (!DAC960_V2_NewPhysicalDeviceInfo(Controller, Channel, TargetID, LogicalUnit))
>  	  break;
>  
> -      PhysicalDeviceInfo = (DAC960_V2_PhysicalDeviceInfo_T *)
> -		kmalloc(sizeof(DAC960_V2_PhysicalDeviceInfo_T), GFP_ATOMIC);
> +      PhysicalDeviceInfo = kmalloc(sizeof(DAC960_V2_PhysicalDeviceInfo_T),
> +				    GFP_ATOMIC);
>        if (PhysicalDeviceInfo == NULL)
>  		return DAC960_Failure(Controller, "PHYSICAL DEVICE ALLOCATION");
>        Controller->V2.PhysicalDeviceInformation[PhysicalDeviceIndex] =
> @@ -2122,8 +2121,8 @@ static boolean DAC960_V2_ReadDeviceConfiguration(DAC960_Controller_T
>        memcpy(PhysicalDeviceInfo, NewPhysicalDeviceInfo,
>  		sizeof(DAC960_V2_PhysicalDeviceInfo_T));
>  
> -      InquiryUnitSerialNumber = (DAC960_SCSI_Inquiry_UnitSerialNumber_T *)
> -	kmalloc(sizeof(DAC960_SCSI_Inquiry_UnitSerialNumber_T), GFP_ATOMIC);
> +      InquiryUnitSerialNumber = kmalloc(
> +	      sizeof(DAC960_SCSI_Inquiry_UnitSerialNumber_T), GFP_ATOMIC);
>        if (InquiryUnitSerialNumber == NULL) {
>  	kfree(PhysicalDeviceInfo);
>  	return DAC960_Failure(Controller, "SERIAL NUMBER ALLOCATION");
> @@ -4949,8 +4948,8 @@ static void DAC960_V2_ProcessCompletedCommand(DAC960_Command_T *Command)
>  	      PhysicalDevice.LogicalUnit = NewLogicalDeviceInfo->LogicalUnit;
>  	      Controller->V2.LogicalDriveToVirtualDevice[LogicalDeviceNumber] =
>  		PhysicalDevice;
> -	      LogicalDeviceInfo = (DAC960_V2_LogicalDeviceInfo_T *)
> -		kmalloc(sizeof(DAC960_V2_LogicalDeviceInfo_T), GFP_ATOMIC);
> +	      LogicalDeviceInfo = kmalloc(sizeof(DAC960_V2_LogicalDeviceInfo_T),
> +					  GFP_ATOMIC);
>  	      Controller->V2.LogicalDeviceInformation[LogicalDeviceNumber] =
>  		LogicalDeviceInfo;
>  	      DAC960_Critical("Logical Drive %d (/dev/rd/c%dd%d) "
> @@ -5709,14 +5708,14 @@ static boolean DAC960_CheckStatusBuffer(DAC960_Controller_T *Controller,
>        unsigned int NewStatusBufferLength = DAC960_InitialStatusBufferSize;
>        while (NewStatusBufferLength < ByteCount)
>  	NewStatusBufferLength *= 2;
> -      Controller->CombinedStatusBuffer =
> -	(unsigned char *) kmalloc(NewStatusBufferLength, GFP_ATOMIC);
> +      Controller->CombinedStatusBuffer = kmalloc(NewStatusBufferLength, 
> +						  GFP_ATOMIC);
>        if (Controller->CombinedStatusBuffer == NULL) return false;
>        Controller->CombinedStatusBufferLength = NewStatusBufferLength;
>        return true;
>      }
> -  NewStatusBuffer = (unsigned char *)
> -    kmalloc(2 * Controller->CombinedStatusBufferLength, GFP_ATOMIC);
> +  NewStatusBuffer = kmalloc(2 * Controller->CombinedStatusBufferLength, 
> +			     GFP_ATOMIC);
>    if (NewStatusBuffer == NULL)
>      {
>        DAC960_Warning("Unable to expand Combined Status Buffer - Truncating\n",
> 
> 
> -- 


---
~Randy

  parent reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-06 13:17 Ahmed S. Darwish
2007-01-06 13:36 ` Robert P. J. Day
2007-01-06 14:55   ` Ahmed S. Darwish
2007-01-06 17:46 ` Randy Dunlap [this message]
2007-01-07  2:00   ` Ahmed S. Darwish
2007-01-07  2:31     ` Randy Dunlap
2007-01-07  2:38     ` Alan
2007-01-07  2:48     ` Jesper Juhl
2007-01-07  2:49     ` Jesper Juhl
2007-01-08 10:09 ` Toon van der Pas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070106094630.51aa62e8.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=darwish.07@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lkml.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lkml.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lkml.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lkml.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lkml.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lkml.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lkml.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lkml.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lkml.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lkml.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lkml.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lkml.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git