LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Pisa <ppisa@pikron.com>
To: Philip Langdale <philipl@overt.org>
Cc: linux-kernel@vger.kernel.org,
	Pierre Ossman <drzeus-list@drzeus.cx>,
	Alex Dubov <oakad@yahoo.com>,
	Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 2.6.19] mmc: Fix handling of response types in imxmmc and tifm drivers
Date: Sun, 7 Jan 2007 18:34:22 +0100	[thread overview]
Message-ID: <200701071834.22893.ppisa@pikron.com> (raw)
In-Reply-To: <459D178F.8000607@overt.org>

Hello Philip,

On Thursday 04 January 2007 16:04, Philip Langdale wrote:
> This change depends on my SDHC patch and fixes a bug that was revealed
> during the development of that patch. The R6 response type should be
> identical to R1 (and R7) but was incorrectly defined differently. Fixing
> the R6 definition breaks assumptions in these two drivers that response
> type flags are unique. Pierre and Alex both believe that treating R6 and R7
> as R1 will be sufficient. ie: The controllers do not care about the
> differences between them. Due to lack of hardware, I have done no testing.

I have tested your patch.
Kernel builds. I have not found much time for testing.
But I would not like to block changes and I am going
for next week to project meeting in Spain, so there is
my reply.

I have 2.6.19 + realtime-patches rt14 on the hand.
I have been able to mount and use some cards, but it
I have observed some problems probably related to timing
when I have tried to change CPU frequency.

I need to find time to do more checking on vanilla and RT kernels
when I return. I have some ideas what could be enhanced to ensure
better MX1 SDHC cards recognition under RT kernels. I am not sure,
what causes other seen problems, but I have observed these things
on RT even without your patch.

Conclusion: I knowledge your patch and admit, that I need to
find time for my homeworks.

Best wishes

               Pavel Pisa



  reply	other threads:[~2007-01-08  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-04 15:04 Philip Langdale
2007-01-07 17:34 ` Pavel Pisa [this message]
2007-01-10 19:02   ` Pierre Ossman
2007-01-19  1:50     ` mmc: correct semantics of the mmc_host_remove Alex Dubov
2007-01-19  8:47       ` Pierre Ossman
2007-01-20  3:46         ` Alex Dubov
2007-01-20 10:21           ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701071834.22893.ppisa@pikron.com \
    --to=ppisa@pikron.com \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oakad@yahoo.com \
    --cc=philipl@overt.org \
    --cc=s.hauer@pengutronix.de \
    --subject='Re: [PATCH 2.6.19] mmc: Fix handling of response types in imxmmc and tifm drivers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).