LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>, Kay Sievers <kay.sievers@novell.com>,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Driver core: fix refcounting bug
Date: Mon, 8 Jan 2007 20:23:59 -0800	[thread overview]
Message-ID: <20070108202359.1e7a6670.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0701081103530.4249-100000@iolanthe.rowland.org>

On Mon, 8 Jan 2007 11:06:44 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:

> This patch (as832) fixes a newly-introduced bug in the driver core.
> When a kobject is assigned to a kset, it must acquire a reference to
> the kset.
> 
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> 
> ---
> 
> The bug was introduced in Kay's "unify /sys/class and /sys/bus at 
> /sys/subsystem" patch.
> 
> I left the assignment of class_dev->kobj.parent as it was, although it is 
> not needed.  The following call to kobject_add() will end up doing the 
> same thing.
> 
> Alan Stern
> 
> P.S.: Tracking down refcounting bugs is a real pain!  I spent an entire 
> afternoon on this one...  :-(
> 
> 
> Index: usb-2.6/drivers/base/class.c
> ===================================================================
> --- usb-2.6.orig/drivers/base/class.c
> +++ usb-2.6/drivers/base/class.c
> @@ -648,7 +648,7 @@ int class_device_add(struct class_device
>  		class_dev->kobj.parent = &parent_class_dev->kobj;
>  	else {
>  		/* assign parent kset for uevent hook */
> -		class_dev->kobj.kset = &parent_class->devices_dir;
> +		class_dev->kobj.kset = kset_get(&parent_class->devices_dir);
>  		/* the device directory in /sys/subsystem/<name>/devices */
>  		class_dev->kobj.parent = &parent_class->devices_dir.kobj;
>  	}

OK, I give up.  What kernel is this against?

More importantly: does 2.6.20-rc4 need fixing?

  reply	other threads:[~2007-01-09  4:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-08 16:06 Alan Stern
2007-01-09  4:23 ` Andrew Morton [this message]
2007-01-09  7:13   ` Greg KH
2007-01-09 14:53     ` Alan Stern
2007-01-17  0:45 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070108202359.1e7a6670.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=kay.sievers@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [PATCH] Driver core: fix refcounting bug' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).