LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com> To: Srivatsa Vaddagiri <vatsa@in.ibm.com> Cc: Benjamin Gilbert <bgilbert@cs.cmu.edu>, linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>, Gautham shenoy <ego@in.ibm.com>, Andrew Morton <akpm@osdl.org>, Pekka Enberg <penberg@cs.helsinki.fi> Subject: [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE] Date: Tue, 9 Jan 2007 16:06:15 +0100 [thread overview] Message-ID: <20070109150615.GF9563@osiris.boeblingen.de.ibm.com> (raw) In-Reply-To: <20070109150351.GD9563@osiris.boeblingen.de.ibm.com> From: Heiko Carstens <heiko.carstens@de.ibm.com> Looks like this was forgotten when CPU_LOCK_[ACQUIRE|RELEASE] was introduced. Cc: Pekka Enberg <penberg@cs.helsinki.fi> Cc: Srivatsa Vaddagiri <vatsa@in.ibm.com> Cc: Gautham Shenoy <ego@in.ibm.com> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com> --- mm/slab.c | 13 +++++-------- 1 files changed, 5 insertions(+), 8 deletions(-) Index: linux-2.6.20-rc3-mm1/mm/slab.c =================================================================== --- linux-2.6.20-rc3-mm1.orig/mm/slab.c +++ linux-2.6.20-rc3-mm1/mm/slab.c @@ -1177,8 +1177,10 @@ static int __cpuinit cpuup_callback(stru int memsize = sizeof(struct kmem_list3); switch (action) { - case CPU_UP_PREPARE: + case CPU_LOCK_ACQUIRE: mutex_lock(&cache_chain_mutex); + break; + case CPU_UP_PREPARE: /* * We need to do this right in the beginning since * alloc_arraycache's are going to use this list. @@ -1264,16 +1266,9 @@ static int __cpuinit cpuup_callback(stru } break; case CPU_ONLINE: - mutex_unlock(&cache_chain_mutex); start_cpu_timer(cpu); break; #ifdef CONFIG_HOTPLUG_CPU - case CPU_DOWN_PREPARE: - mutex_lock(&cache_chain_mutex); - break; - case CPU_DOWN_FAILED: - mutex_unlock(&cache_chain_mutex); - break; case CPU_DEAD: /* * Even if all the cpus of a node are down, we don't free the @@ -1344,6 +1339,8 @@ free_array_cache: continue; drain_freelist(cachep, l3, l3->free_objects); } + break; + case CPU_LOCK_RELEASE: mutex_unlock(&cache_chain_mutex); break; }
next prev parent reply other threads:[~2007-01-09 15:06 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-01-08 17:07 Failure to release lock after CPU hot-unplug canceled Benjamin Gilbert 2007-01-09 12:17 ` Heiko Carstens 2007-01-09 12:27 ` Srivatsa Vaddagiri 2007-01-09 15:03 ` Heiko Carstens 2007-01-09 15:05 ` [patch -mm] call cpu_chain with CPU_DOWN_FAILED if CPU_DOWN_PREPARE failed Heiko Carstens 2007-01-09 15:06 ` Heiko Carstens [this message] 2007-01-10 18:20 ` [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE] Christoph Lameter 2007-01-11 2:30 ` Srivatsa Vaddagiri 2007-01-09 16:34 ` Failure to release lock after CPU hot-unplug canceled Benjamin Gilbert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070109150615.GF9563@osiris.boeblingen.de.ibm.com \ --to=heiko.carstens@de.ibm.com \ --cc=akpm@osdl.org \ --cc=bgilbert@cs.cmu.edu \ --cc=ego@in.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=penberg@cs.helsinki.fi \ --cc=vatsa@in.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).