LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jafo@tummy.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: select() setting ERESTARTNOHAND (514).
Date: Wed, 10 Jan 2007 16:27:47 -0800 (PST)	[thread overview]
Message-ID: <20070110.162747.28789587.davem@davemloft.net> (raw)
In-Reply-To: <20070110234238.GB10791@tummy.com>

From: Sean Reifschneider <jafo@tummy.com>
Date: Wed, 10 Jan 2007 16:42:38 -0700

> In looking at the select() code, I see that there are definitely cases
> where sys_select() or sys_pselect7() can return -ERESTARTNOHAND.  However,
> I don't know if this is expected to be caught elsewhere, or if returning it
> here would send it back to user-space.  Worse, I don't fully understand
> what the impact would be of trapping the ERESTARTNOHAND in the
> sys_select/sys_pselect7 functions would be.

It gets caught by the return into userspace code.

Specifically the signal dispatch should repair that return
value to a valid error return code when it tries to dispatch
the signal that select() set in the task struct.

Note that select() only returns these values when signal_pending()
is true.

  reply	other threads:[~2007-01-11  0:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-10 23:42 Sean Reifschneider
2007-01-11  0:27 ` David Miller [this message]
2007-01-11  1:04   ` Sean Reifschneider
2007-01-11  1:15     ` David Miller
2007-01-11  8:25       ` Sean Reifschneider
2007-01-11 22:22         ` bert hubert
2007-01-24  0:50           ` Sean Reifschneider
2007-01-11  0:37 ` PATCH - x86-64 signed-compare bug, was " Neil Brown
2007-01-11  0:40   ` Andi Kleen
2007-01-11  1:02     ` Neil Brown
2007-01-11  1:37       ` Andi Kleen
2007-01-11  4:09       ` Sean Reifschneider
2007-01-11 19:38       ` Denis Vlasenko
2007-01-11  0:43   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070110.162747.28789587.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jafo@tummy.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: select() setting ERESTARTNOHAND (514).' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).