LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
Cc: Dmitry Torokhov <dtor@insightbb.com>,
	Imre Deak <imre.deak@solidboot.com>,
	linux-kernel@vger.kernel.org, tony@atomide.com
Subject: Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state
Date: Wed, 10 Jan 2007 12:04:08 -0800	[thread overview]
Message-ID: <200701101204.08859.david-b@pacbell.net> (raw)
In-Reply-To: <459D05EC.9010907@rfo.atmel.com>

On Thursday 04 January 2007 5:49 am, Nicolas Ferre wrote:
> 
> I face an issue using the hrtimer instead of the old timer framework 
> (your patch #4/6). It seems that I do not sample at a sufficient rate 
> using hrtimer : I see squares when drawing circles ;-)

Why do you suspect the sample rate rather than e.g. filtering or lowlevel
SPI issues?  Have you verified that e.g. the voltage sensor on ads7843
is giving you the right results?


> Do you know if the hrtimer framework has an issue on at91 or do I have 
> to code something to have a low res timer support in the hrtimer framework ?

No particular notion here ... I thought that if the hrtimer patch wasn't
installed (plus clocksource and clockevents patches, which struck me as
awkward on the at91sam926x parts compared to the at91rm9200) it would work
automagically in low-res timer mode (jiffies) using the same API.

So while applying highres timer patches would be possible, it's not supposed
to matter.  I suspect you could just revert the ads7846 hrtimer patch, to
see if that's the issue.

Did you rule out the issue being with the lowlevel AT91 SPI driver?  It's
been problematic in the past ... there's a bitbanging driver that could
help rule that out (or in).

Another low-effort tweak would be telling Kconfig to use HZ=512 or somesuch.
(A power-of-two value dividing the 32KHz clock better than multiple-of-ten.)
That'd increase the resolution of your "low res" timestamps.

- Dave

  reply	other threads:[~2007-01-10 20:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-22 19:25 David Brownell
2006-12-22 20:35 ` Dmitry Torokhov
2006-12-22 20:40   ` David Brownell
2006-12-27 14:14     ` Imre Deak
2006-12-28 22:37       ` David Brownell
2006-12-29  6:22         ` Dmitry Torokhov
2006-12-29 20:26           ` David Brownell
2007-01-04 13:49             ` Nicolas Ferre
2007-01-10 20:04               ` David Brownell [this message]
2007-02-16 17:37             ` [PATCH] input/spi: add ads7843 support to ads7846 touchscreen driver Nicolas Ferre
2007-02-16 19:08               ` David Brownell
2007-02-19 12:48                 ` Nicolas Ferre
2007-02-19 18:46                   ` David Brownell
2007-02-20  9:19                     ` Nicolas Ferre
2007-03-01  4:49                       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701101204.08859.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=dtor@insightbb.com \
    --cc=imre.deak@solidboot.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@rfo.atmel.com \
    --cc=tony@atomide.com \
    --subject='Re: [patch 2.6.20-rc1 6/6] input: ads7846 directly senses PENUP state' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).