LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, apw@shadowen.org, clameter@engr.sgi.com,
	mm-commits@vger.kernel.org
Subject: Re: - sys_mbind-use-cpuset-accessors-for-mems_allowed.patch removed from -mm tree
Date: Fri, 12 Jan 2007 13:25:13 -0800	[thread overview]
Message-ID: <20070112132513.a14e7e70.pj@sgi.com> (raw)
In-Reply-To: <200701122039.l0CKdTiP028254@shell0.pdx.osdl.net>

Andrew, regarding a patch by Andy:
> +	nodemask_t allowed_nodes;
>  
>  	err = get_nodes(&nodes, nmask, maxnode);
> -	nodes_and(nodes, nodes, current->mems_allowed);
> +	allowed_nodes = cpuset_mems_allowed(current);

Not that it matters now, as we're messing with other variations,
but I notice that the above is (1) better looking than having an
#ifdef, (2) better than being broken in the NUMA yes, CPUSETS no,
config, but (3) burdens this code with another nodemask and
nodes_and() op, even in the case that CPUSETS are not configured.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

           reply	other threads:[~2007-01-12 21:25 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200701122039.l0CKdTiP028254@shell0.pdx.osdl.net>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070112132513.a14e7e70.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=clameter@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --subject='Re: - sys_mbind-use-cpuset-accessors-for-mems_allowed.patch removed from -mm tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).