LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: 2.6.20-rc3-mm1 - git-block.patch causes hard lockups
@ 2007-01-12 16:08 Valdis.Kletnieks
  0 siblings, 0 replies; 4+ messages in thread
From: Valdis.Kletnieks @ 2007-01-12 16:08 UTC (permalink / raw)
  To: Andrew Morton, Jens Axboe; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]

On , Valdis.Kletnieks@vt.edu said:
> On Thu, 04 Jan 2007 22:02:00 PST, Andrew Morton said:
> 
> > 	ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc3/2.6.20-rc3-mm1/

Still seeing this in -rc4-mm1..

> With git-block.patch applied, my system locks up *hard* at system shutdown
> time - even alt-sysrq doesn't do anything.  Need to do the "power button for 5"
> stunt to get the system back.

And today's chef's special is wild crow, tastefully prepared in a stir-fry
with broccoli and mixed asiatic vegetables, served on a bed of steamed rice...

It doesn't look quite as locked up hard when you fix the ##$*&% script that
did an 'echo 0 > /proc/sys/kernel/sysrq' :)

Here's the hand-copied traceback:

__mutex_lock_slowpath+0x22/0xaa
mutex_lock+0xe/0x10
synchronize_rcu+0x23/0xc5
blk_sync_queue+0x1d/0x5a
blk_release_queue+0x19/0x65
kobject_cleanup+0x53/0x72
kobject_release+0x0/0xf
kobject_release+0xd/0xf
kref_put+0x5f/0x6b
kobject_put+0x19/0x1b
blk_put_queue+0x43/0x48
dm_put+0x11f/0x133
dev_remove+0xa3/0xb7
ctl_ioctl+0x24f/0x29f
dev_remove+0x0/0xb7
file_has_perm+0xa7/0xb6
do_ioctl+0x5e/0x77
vfs_ioctl+0x252/0x26f
sys_ioctl+0x5f/0x82
tracesys+0xdc/0xe1


> The system is Fedora Core 6/Rawhide, and the last command issued (from
> /etc/rc6.d/S01reboot) is "/sbin/cryptsetup remove swap".  It hits that,
> and *wham* we're dead.  Works fine if I revert git-block.patch.
> 
> The line from /etc/crypttab for the encrypted swap:
> 
> swap /dev/mapper/VolGroup00-swap /dev/urandom swap,cipher=aes-cbc-essiv:sha256

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 2.6.20-rc3-mm1 - git-block.patch causes hard lockups
  2007-01-08  8:55   ` Jens Axboe
@ 2007-01-09 18:03     ` Valdis.Kletnieks
  0 siblings, 0 replies; 4+ messages in thread
From: Valdis.Kletnieks @ 2007-01-09 18:03 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Andrew Morton, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

On Mon, 08 Jan 2007 09:55:24 +0100, Jens Axboe said:
> On Sat, Jan 06 2007, Valdis.Kletnieks@vt.edu wrote:
> > On Thu, 04 Jan 2007 22:02:00 PST, Andrew Morton said:
> > 
> > > 	ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc
3/2.6.20-rc3-mm1/
> > 
> > With git-block.patch applied, my system locks up *hard* at system
> > shutdown time - even alt-sysrq doesn't do anything.  Need to do the
> > "power button for 5" stunt to get the system back.
> 
> Does this change anything?
> 
> diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
> index ec40e44..bae57e0 100644
> --- a/block/ll_rw_blk.c
> +++ b/block/ll_rw_blk.c
> @@ -1542,7 +1542,7 @@ static inline void queue_sync_plugs(request_queue_t *q)
>  	 * If the current process is plugged and has barriers submitted,
>  	 * we will livelock if we don't unplug first.
>  	 */
> -	blk_unplug_current();
> +	blk_replug_current_nested();
>  
>  	synchronize_qrcu(&q->qrcu);
>  }

Nope, still hangs exactly the same way.  Maybe I need to get the watchdog
timer stuff working, and see if that can kick the system in a way that
produces a backtrace....

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 2.6.20-rc3-mm1 - git-block.patch causes hard lockups
  2007-01-06 12:55 ` 2.6.20-rc3-mm1 - git-block.patch causes hard lockups Valdis.Kletnieks
@ 2007-01-08  8:55   ` Jens Axboe
  2007-01-09 18:03     ` Valdis.Kletnieks
  0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2007-01-08  8:55 UTC (permalink / raw)
  To: Valdis.Kletnieks; +Cc: Andrew Morton, linux-kernel

On Sat, Jan 06 2007, Valdis.Kletnieks@vt.edu wrote:
> On Thu, 04 Jan 2007 22:02:00 PST, Andrew Morton said:
> 
> > 	ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc3/2.6.20-rc3-mm1/
> 
> With git-block.patch applied, my system locks up *hard* at system
> shutdown time - even alt-sysrq doesn't do anything.  Need to do the
> "power button for 5" stunt to get the system back.

Does this change anything?

diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
index ec40e44..bae57e0 100644
--- a/block/ll_rw_blk.c
+++ b/block/ll_rw_blk.c
@@ -1542,7 +1542,7 @@ static inline void queue_sync_plugs(request_queue_t *q)
 	 * If the current process is plugged and has barriers submitted,
 	 * we will livelock if we don't unplug first.
 	 */
-	blk_unplug_current();
+	blk_replug_current_nested();
 
 	synchronize_qrcu(&q->qrcu);
 }

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

* 2.6.20-rc3-mm1 - git-block.patch causes hard lockups
  2007-01-05  6:02 2.6.20-rc3-mm1 Andrew Morton
@ 2007-01-06 12:55 ` Valdis.Kletnieks
  2007-01-08  8:55   ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Valdis.Kletnieks @ 2007-01-06 12:55 UTC (permalink / raw)
  To: Andrew Morton, Jens Axboe; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

On Thu, 04 Jan 2007 22:02:00 PST, Andrew Morton said:

> 	ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20-rc3/2.6.20-rc3-mm1/

With git-block.patch applied, my system locks up *hard* at system shutdown
time - even alt-sysrq doesn't do anything.  Need to do the "power button for 5"
stunt to get the system back.

The system is Fedora Core 6/Rawhide, and the last command issued (from
/etc/rc6.d/S01reboot) is "/sbin/cryptsetup remove swap".  It hits that,
and *wham* we're dead.  Works fine if I revert git-block.patch.

The line from /etc/crypttab for the encrypted swap:

swap /dev/mapper/VolGroup00-swap /dev/urandom swap,cipher=aes-cbc-essiv:sha256

This ring any bells?  I haven't gotten ambitious enough yet to look for
individual commits inside the git-block.patch (this is just one of 3 issues
I've having to bisect in -mm this time around...)

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-01-13  2:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-12 16:08 2.6.20-rc3-mm1 - git-block.patch causes hard lockups Valdis.Kletnieks
  -- strict thread matches above, loose matches on Subject: below --
2007-01-05  6:02 2.6.20-rc3-mm1 Andrew Morton
2007-01-06 12:55 ` 2.6.20-rc3-mm1 - git-block.patch causes hard lockups Valdis.Kletnieks
2007-01-08  8:55   ` Jens Axboe
2007-01-09 18:03     ` Valdis.Kletnieks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).