LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>,
	Linux Kernel List <linux-kernel@vger.kernel.org>,
	jkosina@suse.cz, linux-input@atrey.karlin.mff.cuni.cz,
	Adrian Bunk <bunk@stusta.de>
Subject: Re: Fwd: [PATCH] Fix some ARM builds due to HID brokenness
Date: Fri, 12 Jan 2007 21:53:51 +0000	[thread overview]
Message-ID: <20070112215351.GD24451@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070112214216.GC24451@flint.arm.linux.org.uk>

On Fri, Jan 12, 2007 at 09:42:16PM +0000, Russell King wrote:
> On Fri, Jan 12, 2007 at 09:00:15PM +0000, Russell King wrote:
> > Could we please have this (or a proper fix) in before 2.6.20 to resolve
> > the regression please?
> 
> Actually, this remaining regression is not caused by this patch not being
> integrated, but this:
> 
> config USB_HID
>         tristate "USB Human Interface Device (full HID) support"
>         default y
>         depends on USB
>         select HID
> 
> So... we have USB_HID _newly_ selected in configurations which didn't
> have it before, which overrides CONFIG_HID and builds HID without
> input support.
> 
> Relevant lines from "make ep93xx_defconfig" output:
> 
> Generic input layer (needed for keyboard, mouse, ...) (INPUT) [N/m/y/?] n
> Support for Host-side USB (USB) [Y/n/m/?] y
> USB Human Interface Device (full HID) support (USB_HID) [Y/n/m/?] (NEW) y
> 
> Can USB_HID also depend on INPUT ?

Nevertheless, here's a patch to solve more of the same that my original
patch attempted to solve.  The original patch is still required.  Seems
to solve the final instance of this problem here.

diff --git a/drivers/usb/input/Kconfig b/drivers/usb/input/Kconfig
index 258a5d0..c7d8875 100644
--- a/drivers/usb/input/Kconfig
+++ b/drivers/usb/input/Kconfig
@@ -7,7 +7,7 @@ comment "USB Input Devices"
 config USB_HID
 	tristate "USB Human Interface Device (full HID) support"
 	default y
-	depends on USB
+	depends on USB && INPUT
 	select HID
 	---help---
 	  Say Y here if you want full HID support to connect USB keyboards,


-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2007-01-12 21:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12 21:00 Russell King
2007-01-12 21:42 ` Russell King
2007-01-12 21:53   ` Russell King [this message]
2007-01-13 15:34     ` Jiri Kosina
2007-01-12 21:44 ` Andrew Morton
2007-01-12 22:01   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070112215351.GD24451@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=jkosina@suse.cz \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: Fwd: [PATCH] Fix some ARM builds due to HID brokenness' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).