LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Karsten Keil <kkeil@suse.de>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: any value to fixing apparent bugs in old ISDN4Linux?
Date: Mon, 15 Jan 2007 14:57:18 +0100	[thread overview]
Message-ID: <20070115135718.GC30889@pingi.kke.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0701150634270.1953@CPE00045a9c397f-CM001225dbafb6>

On Mon, Jan 15, 2007 at 06:43:30AM -0500, Robert P. J. Day wrote:
> 
> $ grep -r DE_AOC .
> ./.config:CONFIG_DE_AOC=y
> ./drivers/isdn/hisax/l3dss1.c:#ifdef HISAX_DE_AOC
> ./drivers/isdn/hisax/l3dss1.c:#else  /* not HISAX_DE_AOC */
> ./drivers/isdn/hisax/l3dss1.c:#endif /* not HISAX_DE_AOC */
> ./drivers/isdn/hisax/Kconfig:config DE_AOC
> 
>   it seems like there's a name mismatch between the config variable
> and the one that's being tested, no?
> 
>   OTOH, since that code *is* in the allegedly obsolete old ISDN4Linux
> code, perhaps that entire part of the tree can just be junked.  but if
> it's sticking around, it should probably be fixed.
> 


Yes thanks for discover this. Since the code only affect the
analyse of the AOC info which is pure information only without real
function it was not detected before.

-- 
Karsten Keil
SuSE Labs
ISDN development

  reply	other threads:[~2007-01-15 13:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 11:43 Robert P. J. Day
2007-01-15 13:57 ` Karsten Keil [this message]
2007-01-15 17:09 ` Tilman Schmidt
2007-01-15 17:17   ` Robert P. J. Day
2007-01-15 17:29     ` Karsten Keil
2007-02-21  0:29       ` [PATCH] Remove "obsolete" label from ISDN4Linux (was: any value to fixing apparent bugs in old ISDN4Linux?) Tilman Schmidt
2007-03-28 22:18       ` [Repost][PATCH] Remove "obsolete" label from ISDN4Linux Tilman Schmidt
2007-04-21 13:07       ` [PATCH] Remove "obsolete" label from ISDN4Linux (v3) Tilman Schmidt
2007-04-21 20:58         ` Alan Cox
2007-04-21 22:10           ` David Miller
2007-04-22 12:27             ` Tilman Schmidt
2007-04-22 12:58               ` Alan Cox
2007-04-22 14:29                 ` Tilman Schmidt
2007-04-22 15:17                   ` Alan Cox
2007-04-22 15:48                     ` Satyam Sharma
2007-04-22 16:20                       ` Alan Cox
2007-04-23 23:58                         ` Tilman Schmidt
2007-05-28 16:32       ` [PATCH] ISDN4Linux: fix maturity label (v4) Tilman Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115135718.GC30889@pingi.kke.suse.de \
    --to=kkeil@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: any value to fixing apparent bugs in old ISDN4Linux?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).