LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Simon Budig <simon@budig.de>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Vojtech Pavlik <vojtech@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)
Date: Mon, 15 Jan 2007 18:32:16 +0100	[thread overview]
Message-ID: <20070115173216.GA4582@budig.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0701151743170.16747@twin.jikos.cz>

Jiri Kosina (jikos@jikos.cz) wrote:
> On Mon, 15 Jan 2007, Simon Budig wrote:
> > Yeah, it was easy to port over. Did the hid-debug stuff disappear
> > completely? What would I use instead?
> 
> No, it didn't disappear, it was just moved to include/linux/hid-debug.h. 
> Should I wait for an updated patch that uses hid-debug.h again?

Thanks, I missed that. Since these issues are unrelated I'll just submit
a trivial patch for the hid-debug.h stuff.

Is it possible that there is a regression in the hid-debug stuff? The
mapping does not seem to appear in the dmesg-output. I unfortunately
don't have an earlier kernel available right now to verify, but now the
output on plugging in the device looks like this:

[...]
usbcore: registered new interface driver hiddev
hid-debug: input GenericDesktop.X = 0
hid-debug: input GenericDesktop.Y = 0
hid-debug: input GenericDesktop.Z = 0
hid-debug: input GenericDesktop.Rx = 0
hid-debug: input GenericDesktop.Ry = 0
hid-debug: input GenericDesktop.Rz = 0
[...]

which looks bogus to me, IIRC earlier versions really printed the
mapping to linux input events at this point.

Anyway, the patch is correct anyway, will submit it soon.

Bye,
        Simon
-- 
              simon@budig.de              http://simon.budig.de/

  reply	other threads:[~2007-01-15 17:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-14 23:11 Simon Budig
2007-01-15  8:42 ` Jiri Kosina
2007-01-15 16:25   ` Simon Budig
2007-01-15 16:44     ` Jiri Kosina
2007-01-15 17:32       ` Simon Budig [this message]
2007-01-15 21:14         ` Jiri Kosina
2007-01-15 22:55           ` Simon Budig
2007-01-15 18:32       ` Vojtech Pavlik
2007-01-15 18:38         ` Marcel Holtmann
2007-01-15 18:56           ` Vojtech Pavlik
2007-01-15 16:28 ` [PATCH 2.6.20-rc5] " Simon Budig
2007-01-15 17:34   ` Simon Budig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115173216.GA4582@budig.de \
    --to=simon@budig.de \
    --cc=jikos@jikos.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    --subject='Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).