LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.cz>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Simon Budig <simon@budig.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)
Date: Mon, 15 Jan 2007 19:32:07 +0100	[thread overview]
Message-ID: <20070115183207.GA6792@suse.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0701151743170.16747@twin.jikos.cz>

On Mon, Jan 15, 2007 at 05:44:26PM +0100, Jiri Kosina wrote:
> On Mon, 15 Jan 2007, Simon Budig wrote:
> 
> > > thanks for the patch. It seems that it is based on pre-2.6.20-rc1 kernel 
> > > (this is where the USBHID split happened and generic HID layer was 
> > > introduced). Could you please rebase it against newer version of kernel 
> > > and resend it?
> > I've updated the patch, will submit it to the list in a few minutes.
> 
> I got it, thanks.
> 
> > > All your changes happen to be in the transport-independent code, so it 
> > > seems that this would be rather trivial task - probably only pathnames 
> > > (and diff offsets) will change - your changes should now go to 
> > > drivers/hid/hid-*, not drivers/usb/input/hid-*.
> > Yeah, it was easy to port over. Did the hid-debug stuff disappear
> > completely? What would I use instead?
> 
> No, it didn't disappear, it was just moved to include/linux/hid-debug.h. 

Do you think that makes sense? It's code, not a header file.

> Should I wait for an updated patch that uses hid-debug.h again?

-- 
Vojtech Pavlik
Director SuSE Labs

  parent reply	other threads:[~2007-01-15 18:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-14 23:11 Simon Budig
2007-01-15  8:42 ` Jiri Kosina
2007-01-15 16:25   ` Simon Budig
2007-01-15 16:44     ` Jiri Kosina
2007-01-15 17:32       ` Simon Budig
2007-01-15 21:14         ` Jiri Kosina
2007-01-15 22:55           ` Simon Budig
2007-01-15 18:32       ` Vojtech Pavlik [this message]
2007-01-15 18:38         ` Marcel Holtmann
2007-01-15 18:56           ` Vojtech Pavlik
2007-01-15 16:28 ` [PATCH 2.6.20-rc5] " Simon Budig
2007-01-15 17:34   ` Simon Budig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115183207.GA6792@suse.cz \
    --to=vojtech@suse.cz \
    --cc=jikos@jikos.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon@budig.de \
    --subject='Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).