LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: V4L-DVB Maintainers <v4l-dvb-maintainer@linuxtv.org>,
	Thierry MERLE <thierry.merle@free.fr>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [PATCH 1/9] V4L/DVB (5019): Fix the frame->grabstate update in read() entry point.
Date: Mon, 15 Jan 2007 16:37:05 -0200	[thread overview]
Message-ID: <20070115183705.PS3399200001@infradead.org> (raw)
In-Reply-To: <20070115183647.PS0588920000@infradead.org>


From: Thierry MERLE <thierry.merle@free.fr>

The Coverity checker spotted that in usbvision_v4l2_read(), the variable
"frmx" is never assigned any value different from -1, but it's used an 
an array index in "usbvision->frame[frmx]".
Thanks to Adrian Bunk <bunk@stusta.de> for warning about that.

Signed-off-by: Thierry MERLE <thierry.merle@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

 drivers/media/video/usbvision/usbvision-video.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c
index 8c7eba2..7243337 100644
--- a/drivers/media/video/usbvision/usbvision-video.c
+++ b/drivers/media/video/usbvision/usbvision-video.c
@@ -1080,7 +1080,6 @@ static ssize_t usbvision_v4l2_read(struc
 	int noblock = file->f_flags & O_NONBLOCK;
 	unsigned long lock_flags;
 
-	int frmx = -1;
 	int ret,i;
 	struct usbvision_frame *frame;
 
@@ -1155,7 +1154,7 @@ static ssize_t usbvision_v4l2_read(struc
 		frame->bytes_read = 0;
 
 		/* Mark it as available to be used again. */
-		usbvision->frame[frmx].grabstate = FrameState_Unused;
+		frame->grabstate = FrameState_Unused;
 /* 	} */
 
 	return count;


  parent reply	other threads:[~2007-01-15 19:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 18:36 [PATCH 0/9] V4L/DVB updates Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 3/9] V4L/DVB (5021): Cx88xx: Fix lockup on suspend Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 2/9] V4L/DVB (5020): Fix: disable interrupts while at KM_BOUNCE_READ Mauro Carvalho Chehab
2007-01-15 18:37 ` Mauro Carvalho Chehab [this message]
2007-01-15 18:37 ` [PATCH 7/9] V4L/DVB (5069): Fix bttv and friends on 64bit machines with lots of memory Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 5/9] V4L/DVB (5029): Ks0127 status flags Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 6/9] V4L/DVB (5033): MSI TV@nywhere Plus fixes Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 4/9] V4L/DVB (5024): Fix quickcam communicator driver for big endian architectures Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 8/9] V4L/DVB (5071): Tveeprom: autodetect LG TAPC G701D as tuner type 37 Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 9/9] V4L/DVB (5023): Fix compilation on ppc32 architecture Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115183705.PS3399200001@infradead.org \
    --to=mchehab@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.merle@free.fr \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --subject='Re: [PATCH 1/9] V4L/DVB (5019): Fix the frame->grabstate update in read() entry point.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).