LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: V4L-DVB Maintainers <v4l-dvb-maintainer@linuxtv.org>,
	Robert Hancock <hancockr@shaw.ca>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [PATCH 3/9] V4L/DVB (5021): Cx88xx: Fix lockup on suspend
Date: Mon, 15 Jan 2007 16:37:05 -0200	[thread overview]
Message-ID: <20070115183705.PS7841950003@infradead.org> (raw)
In-Reply-To: <20070115183647.PS0588920000@infradead.org>


From: Robert Hancock <hancockr@shaw.ca>

Suspending with the cx88xx module loaded causes the system to lock up
because the cx88_audio_thread kthread was missing a try_to_freeze()
call, which caused it to go into a tight loop and result in softlockup
when suspending. Fix that.

Signed-off-by: Robert Hancock <hancockr@shaw.ca>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

 drivers/media/video/cx88/cx88-tvaudio.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/cx88/cx88-tvaudio.c b/drivers/media/video/cx88/cx88-tvaudio.c
index 3482e01..2bd84d3 100644
--- a/drivers/media/video/cx88/cx88-tvaudio.c
+++ b/drivers/media/video/cx88/cx88-tvaudio.c
@@ -38,6 +38,7 @@
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/errno.h>
+#include <linux/freezer.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/mm.h>
@@ -961,6 +962,7 @@ int cx88_audio_thread(void *data)
 		msleep_interruptible(1000);
 		if (kthread_should_stop())
 			break;
+		try_to_freeze();
 
 		/* just monitor the audio status for now ... */
 		memset(&t, 0, sizeof(t));


  reply	other threads:[~2007-01-15 19:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 18:36 [PATCH 0/9] V4L/DVB updates Mauro Carvalho Chehab
2007-01-15 18:37 ` Mauro Carvalho Chehab [this message]
2007-01-15 18:37 ` [PATCH 2/9] V4L/DVB (5020): Fix: disable interrupts while at KM_BOUNCE_READ Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 1/9] V4L/DVB (5019): Fix the frame->grabstate update in read() entry point Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 7/9] V4L/DVB (5069): Fix bttv and friends on 64bit machines with lots of memory Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 5/9] V4L/DVB (5029): Ks0127 status flags Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 6/9] V4L/DVB (5033): MSI TV@nywhere Plus fixes Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 4/9] V4L/DVB (5024): Fix quickcam communicator driver for big endian architectures Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 8/9] V4L/DVB (5071): Tveeprom: autodetect LG TAPC G701D as tuner type 37 Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 9/9] V4L/DVB (5023): Fix compilation on ppc32 architecture Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115183705.PS7841950003@infradead.org \
    --to=mchehab@infradead.org \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --subject='Re: [PATCH 3/9] V4L/DVB (5021): Cx88xx: Fix lockup on suspend' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).