LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: V4L-DVB Maintainers <v4l-dvb-maintainer@linuxtv.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: [PATCH 9/9] V4L/DVB (5023): Fix compilation on ppc32 architecture
Date: Mon, 15 Jan 2007 16:37:07 -0200	[thread overview]
Message-ID: <20070115183707.PS1359440009@infradead.org> (raw)
In-Reply-To: <20070115183647.PS0588920000@infradead.org>


From: Mauro Carvalho Chehab <mchehab@infradead.org>

There's a problem, pointed by Meelis Roos <mroos@linux.ee>, that, on ppc32 arch,
with some gcc versions (noticed with prerelease 4.1.2 20061115), compilation 
fails, due the lack of __ucmpdi2 to do the required 64-bit comparision.
This patch takes some sugestions made by Andrew Morton <akpm@osdl.org>,
Stelian Pop <stelian@popies.net> and Segher Boessenkool <segher@kernel.crashing.org>

Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

 drivers/media/video/v4l2-common.c |    9 ++++++++-
 include/linux/videodev2.h         |    9 +++++++++
 2 files changed, 17 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/v4l2-common.c b/drivers/media/video/v4l2-common.c
index 752c82c..b87d571 100644
--- a/drivers/media/video/v4l2-common.c
+++ b/drivers/media/video/v4l2-common.c
@@ -90,8 +90,15 @@ MODULE_LICENSE("GPL");
 char *v4l2_norm_to_name(v4l2_std_id id)
 {
 	char *name;
+	u32 myid = id;
 
-	switch (id) {
+	/* HACK: ppc32 architecture doesn't have __ucmpdi2 function to handle
+	   64 bit comparations. So, on that architecture, with some gcc variants,
+	   compilation fails. Currently, the max value is 30bit wide.
+	 */
+	BUG_ON(myid != id);
+
+	switch (myid) {
 	case V4L2_STD_PAL:
 		name="PAL";		break;
 	case V4L2_STD_PAL_BG:
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 5cb380a..d94e268 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -662,6 +662,15 @@ #define V4L2_STD_SECAM_LC       ((v4l2_s
 #define V4L2_STD_ATSC_8_VSB     ((v4l2_std_id)0x01000000)
 #define V4L2_STD_ATSC_16_VSB    ((v4l2_std_id)0x02000000)
 
+/* FIXME:
+   Although std_id is 64 bits, there is an issue on PPC32 architecture that
+   makes switch(__u64) to break. So, there's a hack on v4l2-common.c rounding
+   this value to 32 bits.
+   As, currently, the max value is for V4L2_STD_ATSC_16_VSB (30 bits wide),
+   it should work fine. However, if needed to add more than two standards,
+   v4l2-common.c should be fixed.
+ */
+
 /* some merged standards */
 #define V4L2_STD_MN	(V4L2_STD_PAL_M|V4L2_STD_PAL_N|V4L2_STD_PAL_Nc|V4L2_STD_NTSC)
 #define V4L2_STD_B	(V4L2_STD_PAL_B|V4L2_STD_PAL_B1|V4L2_STD_SECAM_B)


      parent reply	other threads:[~2007-01-15 19:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 18:36 [PATCH 0/9] V4L/DVB updates Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 3/9] V4L/DVB (5021): Cx88xx: Fix lockup on suspend Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 2/9] V4L/DVB (5020): Fix: disable interrupts while at KM_BOUNCE_READ Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 1/9] V4L/DVB (5019): Fix the frame->grabstate update in read() entry point Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 7/9] V4L/DVB (5069): Fix bttv and friends on 64bit machines with lots of memory Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 5/9] V4L/DVB (5029): Ks0127 status flags Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 6/9] V4L/DVB (5033): MSI TV@nywhere Plus fixes Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 4/9] V4L/DVB (5024): Fix quickcam communicator driver for big endian architectures Mauro Carvalho Chehab
2007-01-15 18:37 ` [PATCH 8/9] V4L/DVB (5071): Tveeprom: autodetect LG TAPC G701D as tuner type 37 Mauro Carvalho Chehab
2007-01-15 18:37 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115183707.PS1359440009@infradead.org \
    --to=mchehab@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --subject='Re: [PATCH 9/9] V4L/DVB (5023): Fix compilation on ppc32 architecture' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).