LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: bob.picco@hp.com, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CPUSET related breakage of sys_mbind
Date: Mon, 15 Jan 2007 20:14:06 -0800	[thread overview]
Message-ID: <20070115201406.bf67c773.pj@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0701151950200.15083@schroedinger.engr.sgi.com>

Christoph wrote:
> Cpusets is your thing so I think you could fix this the right way.

But wasn't it your patch that broke ...

Actually, I'd have blessed Bob Picco's patch, as it's done the right
way, with a cpuset_* macro hook, defined twice in cpuset.h, with and
without CONFIG_CPUSET, where the without case compiles to a no-op.
This is the same way as is used for the couple dozen other cpuset
kernel hooks.

But I thought you were already signed up for this one, so I didn't want
to trample on your efforts.

And, perhaps more important, I understood you had some other patches in
the works that have cpuset hooks.  I'm thinking it would be a good idea
to learn how these hooks are done, so we don't have to come around here
again.

How about this ... you take another look at Bob's patch.  If it's ok by
you too, then we can both bless it, and that should do it.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

  reply	other threads:[~2007-01-16  4:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 23:10 Bob Picco
2007-01-16  2:43 ` Paul Jackson
2007-01-16  3:51   ` Christoph Lameter
2007-01-16  4:14     ` Paul Jackson [this message]
2007-01-16  4:46 ` Paul Jackson
2007-01-16 19:48   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115201406.bf67c773.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=bob.picco@hp.com \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] CPUSET related breakage of sys_mbind' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).