LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Williamson <mark.williamson@cl.cam.ac.uk>
To: xen-devel@lists.xensource.com
Cc: Arjan van de Ven <arjan@infradead.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Andrew Morton <akpm@osdl.org>,
Ian Pratt <ian.pratt@xensource.com>,
linux-kernel@vger.kernel.org, Chris Wright <chrisw@sous-sol.org>,
virtualization@lists.osdl.org,
Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
Subject: Re: [Xen-devel] Re: [patch 20/20] XEN-paravirt: Add Xen virtual block device driver.
Date: Tue, 16 Jan 2007 02:53:42 +0000 [thread overview]
Message-ID: <200701160253.43218.mark.williamson@cl.cam.ac.uk> (raw)
In-Reply-To: <1168736848.3123.352.camel@laptopd505.fenrus.org>
> > +
> > + err = xenbus_printf(xbt, dev->nodename,
> > + "ring-ref","%u", info->ring_ref);
>
> why do you need your own printf?
xenbus_printf isn't a printf replacement - it is used for writing a formatted
string into XenStore (which contains VM configuration data in a
human-readable form).
Internally it does a vsnprintf into a buffer and writes the resulting string
to the XenStore.
Cheers,
Mark
> > +static inline int GET_ID_FROM_FREELIST(
>
> does this really need screaming?
>
> > +
> > +int blkif_ioctl(struct inode *inode, struct file *filep,
> > + unsigned command, unsigned long argument)
> > +{
> > + int i;
> > +
> > + DPRINTK_IOCTL("command: 0x%x, argument: 0x%lx, dev: 0x%04x\n",
> > + command, (long)argument, inode->i_rdev);
> > +
> > + switch (command) {
> > + case CDROMMULTISESSION:
> > + DPRINTK("FIXME: support multisession CDs later\n");
> > + for (i = 0; i < sizeof(struct cdrom_multisession); i++)
> > + if (put_user(0, (char __user *)(argument + i)))
> > + return -EFAULT;
> > + return 0;
> > +
> > + default:
> > + /*printk(KERN_ALERT "ioctl %08x not supported by Xen blkdev\n",
> > + command);*/
> > + return -EINVAL; /* same return as native Linux */
> > + }
>
> eh so you implement no ioctls.. why then implement the ioctl method at
> all?
I'm not familiar with this code... but perhaps the (fake) multisession
handling is to keep userspace that queries this happy? I can't really think
of anywhere this would apply off the top of my head, though.
Cheers,
Mark
> > +static struct xenbus_driver blkfront = {
> > + .name = "vbd",
> > + .owner = THIS_MODULE,
> > + .ids = blkfront_ids,
> > + .probe = blkfront_probe,
> > + .remove = blkfront_remove,
> > + .resume = blkfront_resume,
> > + .otherend_changed = backend_changed,
> > +};
>
> this can be const
>
> > +
> > +#define DPRINTK(_f, _a...) pr_debug(_f, ## _a)
>
> why this silly abstraction? Just use pr_debug in the code directly
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
Dave: Just a question. What use is a unicyle with no seat? And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!
next prev parent reply other threads:[~2007-01-16 3:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-13 1:45 [patch 00/20] XEN-paravirt: Xen guest implementation for paravirt_ops interface Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 01/20] XEN-paravirt: Fix typo in sync_constant_test_bit()s name Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 02/20] XEN-paravirt: Add a flag to allow the VGA console to be disabled Jeremy Fitzhardinge
2007-01-14 0:27 ` [Xen-devel] " Alan
2007-01-13 1:45 ` [patch 03/20] XEN-paravirt: paravirt: page-table accessors Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 04/20] XEN-paravirt: paravirt pagetable init Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 05/20] XEN-paravirt: paravirt: reserve fixmap slot Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 06/20] XEN-paravirt: remove pgd ctor Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 07/20] XEN-paravirt: paravirt shared kernel pmd flag Jeremy Fitzhardinge
2007-01-15 8:59 ` [Xen-devel] " Jan Beulich
2007-01-13 1:45 ` [patch 08/20] XEN-paravirt: paravirt pgd allocation alignment Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 09/20] XEN-paravirt: dont export paravirt_ops structure, do individual functions Jeremy Fitzhardinge
2007-01-14 0:57 ` Rusty Russell
2007-01-13 1:45 ` [patch 10/20] XEN-paravirt: mm lifetime hooks Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 11/20] XEN-paravirt: Add apply_to_page_range() which applies a function to a pte range Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 12/20] XEN-paravirt: Xen: Add nosegneg capability to the vsyscall page notes Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 13/20] XEN-paravirt: Xen: Add config options and disable unsupported config options Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 15/20] XEN-paravirt: Xen: core paravirt guest changes Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 16/20] XEN-paravirt: Add the Xen virtual console driver Jeremy Fitzhardinge
2007-01-14 0:37 ` Alan
2007-01-14 0:35 ` Jeremy Fitzhardinge
2007-01-15 13:03 ` Pavel Machek
2007-01-19 4:11 ` Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 17/20] XEN-paravirt: Add Xen grant table support Jeremy Fitzhardinge
2007-01-15 13:05 ` Pavel Machek
2007-01-19 4:07 ` Jeremy Fitzhardinge
2007-01-13 1:45 ` [patch 18/20] XEN-paravirt: Add Xen driver utility functions Jeremy Fitzhardinge
2007-01-14 7:41 ` Greg KH
2007-01-13 1:45 ` [patch 19/20] XEN-paravirt: Add the Xenbus sysfs and virtual device hotplug driver Jeremy Fitzhardinge
2007-01-15 13:18 ` Pavel Machek
2007-01-13 1:45 ` [patch 20/20] XEN-paravirt: Add Xen virtual block device driver Jeremy Fitzhardinge
2007-01-14 1:07 ` Arjan van de Ven
2007-01-14 7:43 ` Greg KH
2007-01-16 2:53 ` Mark Williamson [this message]
2007-01-14 11:05 ` Jan Engelhardt
2007-01-14 11:24 ` Muli Ben-Yehuda
2007-01-14 11:35 ` Jan Engelhardt
2007-01-14 12:37 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701160253.43218.mark.williamson@cl.cam.ac.uk \
--to=mark.williamson@cl.cam.ac.uk \
--cc=Christian.Limpach@cl.cam.ac.uk \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=chrisw@sous-sol.org \
--cc=ian.pratt@xensource.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
--subject='Re: [Xen-devel] Re: [patch 20/20] XEN-paravirt: Add Xen virtual block device driver.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).