LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Dipankar Sarma <dipankar@in.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [mm PATCH 6/6] RCU: trivial fixes
Date: Tue, 16 Jan 2007 09:56:48 -0800	[thread overview]
Message-ID: <20070116175648.GH1776@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070115193103.GG32238@in.ibm.com>

On Tue, Jan 16, 2007 at 01:01:03AM +0530, Dipankar Sarma wrote:
> 
> Fix a few trivial things based on review comments.

Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> Signed-off-by: Dipankar Sarma <dipankar@in.ibm.com>
> 
> ---
> 
> 
> 
> diff -puN kernel/rcupreempt.c~rcu-fix-trivials kernel/rcupreempt.c
> --- linux-2.6.20-rc3-mm1-rcu/kernel/rcupreempt.c~rcu-fix-trivials	2007-01-15 15:37:00.000000000 +0530
> +++ linux-2.6.20-rc3-mm1-rcu-dipankar/kernel/rcupreempt.c	2007-01-15 15:37:00.000000000 +0530
> @@ -156,7 +156,7 @@ void __rcu_read_lock(void)
>  		local_irq_save(oldirq);
> 
>  		/*
> -		 * Outermost nesting of rcu_read_lock(), so atomically
> +		 * Outermost nesting of rcu_read_lock(), so
>  		 * increment the current counter for the current CPU.
>  		 */
>  		idx = rcu_ctrlblk.completed & 0x1;
> @@ -169,7 +169,7 @@ void __rcu_read_lock(void)
>  		 * Now that the per-CPU counter has been incremented, we
>  		 * are protected.  We can therefore safely increment
>  		 * the nesting counter, relieving further NMIs of the
> -		 * need to do so.
> +		 * need to increment the per-CPU counter.
>  		 */
>  		current->rcu_read_lock_nesting = nesting + 1;
>  		barrier();
> 
> _

      reply	other threads:[~2007-01-16 17:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-15 19:19 [mm PATCH] RCU: various patches Dipankar Sarma
2007-01-15 19:21 ` [mm PATCH 1/6] RCU: split classic rcu Dipankar Sarma
2007-01-16 17:49   ` Paul E. McKenney
2007-01-15 19:22 ` [mm PATCH 2/6] RCU: softirq for RCU Dipankar Sarma
2007-01-16 17:49   ` Paul E. McKenney
2007-01-15 19:24 ` [mm PATCH 3/6] RCU: Fix barriers Dipankar Sarma
2007-01-16 17:53   ` Paul E. McKenney
2007-01-15 19:28 ` [mm PATCH 4/6] RCU: preemptible RCU Dipankar Sarma
2007-01-24  0:32   ` Andrew Morton
2007-01-26 21:00     ` Dipankar Sarma
2007-01-26 21:25       ` Andrew Morton
2007-01-24  0:38   ` Andrew Morton
2007-01-15 19:30 ` [mm PATCH 5/6] RCU: debug trace for RCU Dipankar Sarma
2007-01-15 19:31 ` [mm PATCH 6/6] RCU: trivial fixes Dipankar Sarma
2007-01-16 17:56   ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070116175648.GH1776@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@osdl.org \
    --cc=dipankar@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [mm PATCH 6/6] RCU: trivial fixes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).