LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Juergen Beisert <juergen127@kreuzholzen.de>
To: linux-kernel@vger.kernel.org
Cc: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
	takada <takada@mbf.nifty.com>
Subject: Re: fix typo in geode_configre()@cyrix.c
Date: Wed, 17 Jan 2007 01:15:48 +0100	[thread overview]
Message-ID: <200701170115.49168.juergen127@kreuzholzen.de> (raw)
In-Reply-To: <20070109154342.GB17269@csclub.uwaterloo.ca>

On Tuesday 09 January 2007 16:43, Lennart Sorensen wrote:
> On Tue, Jan 09, 2007 at 06:41:56PM +0900, takada wrote:
> > In kernel 2.6, write back wrong register when configure Geode processor.
> > Instead of storing to CCR4, it stores to CCR3.
> >
> > --- linux-2.6.19/arch/i386/kernel/cpu/cyrix.c.orig	2007-01-09
> > 16:45:21.000000000 +0900 +++
> > linux-2.6.19/arch/i386/kernel/cpu/cyrix.c	2007-01-09 17:10:13.000000000
> > +0900 @@ -173,7 +173,7 @@ static void __cpuinit geode_configure(vo
> >  	ccr4 = getCx86(CX86_CCR4);
> >  	ccr4 |= 0x38;		/* FPU fast, DTE cache, Mem bypass */
> >
> > -	setCx86(CX86_CCR3, ccr3);
> > +	setCx86(CX86_CCR4, ccr4);
> >
> >  	set_cx86_memwb();
> >  	set_cx86_reorder();
>
> Any idea what the consequence of this would be?  Any chance that while
> fixing this file anyhow, adding a missing variant could be done?

Writing back of ccr4 should be intented here, but also writing back the ccr3 
to disable the MAPEN again. So both are required. But the ccr4 first:

   setCx86(CX86_CCR4, ccr4);
   setCx86(CX86_CCR3, ccr3);

Juergen

  reply	other threads:[~2007-01-17  0:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-09  9:41 takada
2007-01-09 15:43 ` Lennart Sorensen
2007-01-17  0:15   ` Juergen Beisert [this message]
2007-01-09 17:33 ` Lennart Sorensen
2007-01-16 16:38   ` takada
2007-01-16 16:50     ` Lennart Sorensen
2007-01-16 17:12       ` takada
2007-01-24  4:04         ` Andrew Morton
2007-01-16 22:47     ` Lennart Sorensen
2007-01-17  0:24   ` Juergen Beisert
2007-01-17 15:26   ` takada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701170115.49168.juergen127@kreuzholzen.de \
    --to=juergen127@kreuzholzen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsorense@csclub.uwaterloo.ca \
    --cc=takada@mbf.nifty.com \
    --subject='Re: fix typo in geode_configre()@cyrix.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).