LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] fix emergency reboot: call reboot notifier list if possible
Date: Wed, 17 Jan 2007 10:39:17 +0100 [thread overview]
Message-ID: <20070117093917.GA7538@elte.hu> (raw)
In-Reply-To: <20070117092233.GA30197@flint.arm.linux.org.uk>
* Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> On Wed, Jan 17, 2007 at 10:13:19AM +0100, Ingo Molnar wrote:
> > we dont call the reboot notifiers during emergency reboot mainly because
> > it could be called from atomic context and reboot notifiers are a
> > blocking notifier list. But actually the kernel is often perfectly
> > reschedulable in this stage, so we could as well process the
> > reboot_notifier_list.
>
> My experience has been that when there has been the need to use this
> facility, the kernel hasn't been reschedulable. [...]
this decision is totally automatic - so if your situation happens and
the kernel isnt reschedulable, then the notifier chain wont be called
and nothing changes from your perspective. Hm, perhaps this should be
dependent on CONFIG_PREEMPT, to make sure preempt_count() is reliable?
but from my perspective this patch fixes a real regression.
updated patch attached below.
Ingo
-------------------->
Subject: [patch] call reboot notifier list when doing an emergency reboot
From: Ingo Molnar <mingo@elte.hu>
my laptop does not reboot unless the shutdown notifiers are called
first. So the following command, which i use as a fast way to reboot
into a new kernel:
echo b > /proc/sysrq-trigger
just hangs indefinitely after the kernel prints "System rebooting".
the thing is, that the kernel is actually reschedulable in this stage,
so we could as well process the reboot_notifier_list. (furthermore,
on -rt kernels this place is preemptable even during SysRq-b)
So just process the reboot notifier list if we are preemptable. This
will shut disk caches and chipsets off.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sys.c | 10 ++++++++++
1 file changed, 10 insertions(+)
Index: linux/kernel/sys.c
===================================================================
--- linux.orig/kernel/sys.c
+++ linux/kernel/sys.c
@@ -29,6 +29,7 @@
#include <linux/signal.h>
#include <linux/cn_proc.h>
#include <linux/getcpu.h>
+#include <linux/hardirq.h>
#include <linux/compat.h>
#include <linux/syscalls.h>
@@ -710,6 +711,15 @@ out_unlock:
*/
void emergency_restart(void)
{
+ /*
+ * Call the notifier chain if we are not in an
+ * atomic context:
+ */
+#ifdef CONFIG_PREEMPT
+ if (!in_atomic() && !irqs_disabled())
+ blocking_notifier_call_chain(&reboot_notifier_list,
+ SYS_RESTART, NULL);
+#endif
machine_emergency_restart();
}
EXPORT_SYMBOL_GPL(emergency_restart);
next prev parent reply other threads:[~2007-01-17 9:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 9:13 Ingo Molnar
2007-01-17 9:22 ` Russell King
2007-01-17 9:39 ` Ingo Molnar [this message]
2007-01-17 10:03 ` Andrew Morton
2007-01-17 10:25 ` Ingo Molnar
2007-01-23 19:57 ` Pavel Machek
2007-01-24 16:30 ` Randy Dunlap
2007-01-24 17:49 ` linux-os (Dick Johnson)
2007-01-17 9:51 ` [patch] KVM: do VMXOFF upon reboot Ingo Molnar
2007-01-17 10:02 ` Ingo Molnar
2007-01-21 10:17 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070117093917.GA7538@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--subject='Re: [patch] fix emergency reboot: call reboot notifier list if possible' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).