LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Sébastien Dugué" <sebastien.dugue@bull.net>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-aio <linux-aio@kvack.org>,
Bharata B Rao <bharata@in.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Suparna Bhattacharya <suparna@in.ibm.com>,
Ulrich Drepper <drepper@redhat.com>,
Zach Brown <zach.brown@oracle.com>,
Jean Pierre Dion <jean-pierre.dion@bull.net>,
Badari Pulavarty <pbadari@us.ibm.com>
Subject: [PATCH -mm 3/5][AIO] - Make good_sigevent non-static
Date: Wed, 17 Jan 2007 10:49:33 +0100 [thread overview]
Message-ID: <20070117104933.343a3224@frecb000686> (raw)
In-Reply-To: <20070117104601.36b2ab18@frecb000686>
Make good_sigevent() non-static
Move good_sigevent() from posix-timers.c to signal.c where it belongs,
and make it non-static so that it can be used by other subsystems.
include/linux/signal.h | 1 +
kernel/posix-timers.c | 17 -----------------
kernel/signal.c | 24 ++++++++++++++++++++++++
3 files changed, 25 insertions(+), 17 deletions(-)
Signed-off-by: Sébastien Dugué <sebastien.dugue@bull.net>
Index: linux-2.6.20-rc4-mm1/include/linux/signal.h
===================================================================
--- linux-2.6.20-rc4-mm1.orig/include/linux/signal.h 2007-01-12 11:40:30.000000000 +0100
+++ linux-2.6.20-rc4-mm1/include/linux/signal.h 2007-01-12 12:15:06.000000000 +0100
@@ -240,6 +240,7 @@ extern int sigprocmask(int, sigset_t *,
struct pt_regs;
extern int get_signal_to_deliver(siginfo_t *info, struct k_sigaction *return_ka, struct pt_regs *regs, void *cookie);
+extern struct task_struct * good_sigevent(sigevent_t *);
extern struct kmem_cache *sighand_cachep;
Index: linux-2.6.20-rc4-mm1/kernel/posix-timers.c
===================================================================
--- linux-2.6.20-rc4-mm1.orig/kernel/posix-timers.c 2007-01-12 11:40:39.000000000 +0100
+++ linux-2.6.20-rc4-mm1/kernel/posix-timers.c 2007-01-12 12:15:06.000000000 +0100
@@ -367,23 +367,6 @@ static enum hrtimer_restart posix_timer_
return ret;
}
-static struct task_struct * good_sigevent(sigevent_t * event)
-{
- struct task_struct *rtn = current->group_leader;
-
- if ((event->sigev_notify & SIGEV_THREAD_ID ) &&
- (!(rtn = find_task_by_pid(event->sigev_notify_thread_id)) ||
- rtn->tgid != current->tgid ||
- (event->sigev_notify & ~SIGEV_THREAD_ID) != SIGEV_SIGNAL))
- return NULL;
-
- if (((event->sigev_notify & ~SIGEV_THREAD_ID) != SIGEV_NONE) &&
- ((event->sigev_signo <= 0) || (event->sigev_signo > SIGRTMAX)))
- return NULL;
-
- return rtn;
-}
-
void register_posix_clock(const clockid_t clock_id, struct k_clock *new_clock)
{
if ((unsigned) clock_id >= MAX_CLOCKS) {
Index: linux-2.6.20-rc4-mm1/kernel/signal.c
===================================================================
--- linux-2.6.20-rc4-mm1.orig/kernel/signal.c 2007-01-12 11:40:39.000000000 +0100
+++ linux-2.6.20-rc4-mm1/kernel/signal.c 2007-01-12 12:15:06.000000000 +0100
@@ -1213,6 +1213,30 @@ int group_send_sig_info(int sig, struct
return ret;
}
+/***
+ * good_sigevent - check and get target task from a sigevent.
+ * @event: the sigevent to be checked
+ *
+ * This function must be called with the tasklist_lock held for reading.
+ */
+struct task_struct * good_sigevent(sigevent_t * event)
+{
+ struct task_struct *task = current->group_leader;
+
+ if ((event->sigev_notify & SIGEV_THREAD_ID ) == SIGEV_THREAD_ID) {
+ task = find_task_by_pid(event->sigev_notify_thread_id);
+
+ if (!task || task->tgid != current->tgid)
+ return NULL;
+ } else if (event->sigev_notify == SIGEV_SIGNAL) {
+ if ((event->sigev_signo <= 0) || (event->sigev_signo > SIGRTMAX))
+ return NULL;
+ } else
+ return NULL;
+
+ return task;
+}
+
/*
* kill_pgrp_info() sends a signal to a process group: this is what the tty
* control characters do (^C, ^Z etc)
next prev parent reply other threads:[~2007-01-17 9:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070117104601.36b2ab18@frecb000686>
2007-01-17 9:48 ` [PATCH -mm 1/5][AIO] - Rework compat_sys_io_submit Sébastien Dugué
2007-01-17 9:48 ` [PATCH -mm 2/5][AIO] - fix aio.h includes Sébastien Dugué
2007-01-17 9:49 ` Sébastien Dugué [this message]
2007-01-17 9:50 ` [PATCH -mm 4/5][AIO] - AIO completion signal notification Sébastien Dugué
2007-01-24 5:35 ` Andrew Morton
2007-01-24 11:11 ` Sébastien Dugué
2007-01-25 5:42 ` Christoph Hellwig
2007-01-25 8:46 ` Sébastien Dugué
2007-01-17 9:55 ` [PATCH -mm 5/5][AIO] - Add listio syscall support Sébastien Dugué
2007-01-24 5:50 ` Andrew Morton
2007-01-24 11:51 ` Sébastien Dugué
2007-01-24 5:53 ` Andrew Morton
2007-01-24 9:52 ` Laurent Vivier
2007-01-24 11:53 ` Sébastien Dugué
2007-01-24 6:04 ` Andrew Morton
2007-01-24 12:02 ` Sébastien Dugué
2007-01-24 18:16 ` Bharata B Rao
2006-11-30 15:38 [PATCH -mm 0/5][AIO] - AIO completion signal notification v4 Sébastien Dugué
2006-11-30 15:50 ` [PATCH -mm 3/5][AIO] - Make good_sigevent non-static Sébastien Dugué
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070117104933.343a3224@frecb000686 \
--to=sebastien.dugue@bull.net \
--cc=akpm@osdl.org \
--cc=bharata@in.ibm.com \
--cc=drepper@redhat.com \
--cc=hch@infradead.org \
--cc=jean-pierre.dion@bull.net \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=suparna@in.ibm.com \
--cc=zach.brown@oracle.com \
--subject='Re: [PATCH -mm 3/5][AIO] - Make good_sigevent non-static' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).