LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	JFS Discussion <jfs-discussion@lists.sourceforge.net>,
	fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging
Date: Thu, 18 Jan 2007 01:30:19 -0500	[thread overview]
Message-ID: <20070118063019.GA31164@filer.fsl.cs.sunysb.edu> (raw)
In-Reply-To: <1169074549.10560.10.camel@kleikamp.austin.ibm.com>

On Wed, Jan 17, 2007 at 04:55:49PM -0600, Dave Kleikamp wrote:
...
> diff -Nurp linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h linux/fs/jfs/jfs_lock.h
> --- linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h	2006-11-29 15:57:37.000000000 -0600
> +++ linux/fs/jfs/jfs_lock.h	2007-01-17 15:30:19.000000000 -0600
> @@ -22,6 +22,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/mutex.h>
>  #include <linux/sched.h>
> +#include <linux/blkdev.h>
>  
>  /*
>   *	jfs_lock.h
> @@ -42,6 +43,7 @@ do {							\
>  		if (cond)				\
>  			break;				\
>  		unlock_cmd;				\
> +		blk_replug_current_nested();		\
>  		schedule();				\
>  		lock_cmd;				\
>  	}						\

Is {,un}lock_cmd a macro? ...

Jeff.

-- 
Keyboard not found!
Press F1 to enter Setup

  parent reply	other threads:[~2007-01-18  6:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-17 22:55 Dave Kleikamp
2007-01-17 23:18 ` Jens Axboe
2007-01-17 23:39   ` Dave Kleikamp
2007-01-17 23:46     ` Jens Axboe
2007-01-18  3:23       ` Dave Kleikamp
2007-01-18  6:30 ` Josef Sipek [this message]
2007-01-18 14:15   ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070118063019.GA31164@filer.fsl.cs.sunysb.edu \
    --to=jsipek@fsl.cs.sunysb.edu \
    --cc=jens.axboe@oracle.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=shaggy@linux.vnet.ibm.com \
    --subject='Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).