LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andreas Mohr <andim2@users.sourceforge.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: andi@lisas.de, davej@codemonkey.org.uk,
	kernel list <linux-kernel@vger.kernel.org>
Subject: intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram)
Date: Thu, 18 Jan 2007 12:51:05 +0100	[thread overview]
Message-ID: <20070118115105.GA28233@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <20070117005755.GB6270@elf.ucw.cz>

Hi,

On Wed, Jan 17, 2007 at 01:57:55AM +0100, Pavel Machek wrote:
> > Especially the PCI video_state trick finally got me a working resume on
> > 2.6.19-ck2 r128 Rage Mobility M4 AGP *WITH*(!) fully enabled and working
> > (and keeping working!) DRI (3D).
> 
> Can we get whitelist entry for suspend.sf.net? s2ram from there can do
> all the tricks you described, one letter per trick :-). We even got
> PCI saving lately.

Whitelist? Let me blacklist it all the way to Timbuktu instead!

I've been doing more testing, and X never managed to come back to working
state without some of my couple intel-agp changes:
- a proper suspend method, doing a proper pci_save_state()
  or improved equivalent
- a missing resume check for my i815 chipset
- global cache flush in _configure
- restoring AGP bridge PCI config space

The remaining suspects (the other hacks alone didn't recover it)
are global cache flush and restoring of the *entire* AGP bridge PCI
config space (no, a 64-bytes-only pci_restore_state() alone doesn't help,
and it didn't help either that intel-agp doesn't do pci_save_state() anywhere
 - unless that's now done by default by PCI layer).
I'll do more testing today to isolate which change exactly fixed it.

All in all intel-agp code semi-shattered my universe.
I didn't expect to find all these issues in rather important core code
for a wide-spread chipset vendor - it doesn't even log an
"unhandled chipset: resuming may fail, please report!" message
in the resume handler in case of a missing chipset check
(although it may be debatable whether people are able to see this message
at all).
However since the new AGP code was a heroic refactoring effort
it's understandable that there are some remaining issues.

Given the myriads of resume issues we experience in general,
it may be wise to do something as simple as a code review of *all*
relevant code no matter how "complete" we expect each driver to be...
(one could e.g. start with reviewing all other AGP chipset drivers).

Andreas Mohr

  reply	other threads:[~2007-01-18 11:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-16 13:57 2.6.20-rc5: usb mouse breaks suspend to ram Pavel Machek
2007-01-16 14:08 ` Dmitry Torokhov
2007-01-16 14:24   ` Pavel Machek
2007-01-16 21:25     ` Dmitry Torokhov
2007-01-16 21:47       ` Pavel Machek
2007-01-17 15:44         ` [linux-usb-devel] " Alan Stern
2007-01-17  0:40       ` Andreas Mohr
2007-01-17  0:57         ` Pavel Machek
2007-01-18 11:51           ` Andreas Mohr [this message]
2007-01-18 22:05             ` intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram) Nigel Cunningham
2007-01-18 23:16             ` Pavel Machek
2007-01-22  4:45               ` Wang Zhenyu
2007-01-23  9:44                 ` i965 testers wanted (Re: intel-agp PM experiences) Pavel Machek
2007-01-23 14:46                   ` Sunil Naidu
2007-01-29 22:05                   ` Frédéric Riss
2007-01-29 22:10                     ` Pavel Machek
2007-01-29 22:21                       ` Frédéric Riss
2007-01-29 22:34                         ` Dave Jones
2007-01-29 21:30                 ` intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram) Andreas Mohr
2007-01-30 12:36                   ` Wang Zhenyu
2007-01-30 13:05                     ` Andreas Mohr
2007-01-30 23:39                     ` Andreas Mohr
2007-05-01 14:59               ` [PATCH -mm] working 3D/DRI intel-agp.ko resume for i815 chip; Intel chipset testers wanted! (was: Re: intel-agp PM experiences ...) Andreas Mohr
2007-05-02 10:17                 ` Pavel Machek
2007-05-03 15:47                   ` Dave Jones
2007-05-05 17:56                   ` Andreas Mohr
2007-05-10  6:44                     ` Andreas Mohr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070118115105.GA28233@rhlx01.hs-esslingen.de \
    --to=andim2@users.sourceforge.net \
    --cc=andi@lisas.de \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --subject='Re: intel-agp PM experiences (was: 2.6.20-rc5: usb mouse breaks suspend to ram)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).